]> gcc.gnu.org Git - gcc.git/commit
AArch32: Fix 128-bit sequential consistency atomic operations.
authorTamar Christina <tamar.christina@arm.com>
Mon, 8 Aug 2022 13:37:42 +0000 (14:37 +0100)
committerTamar Christina <tamar.christina@arm.com>
Mon, 8 Aug 2022 13:37:42 +0000 (14:37 +0100)
commit5471f55f001af412e1125b04972ebaab9d4f7337
treed9e8fe8daf896f3984fda1914d521d51aa7fbfff
parente6a8ae900b4141bbce1451da8f173d441662782d
AArch32: Fix 128-bit sequential consistency atomic operations.

Similar to AArch64 the Arm implementation of 128-bit atomics is broken.

For 128-bit atomics we rely on pthread barriers to correct guard the address
in the pointer to get correct memory ordering.  However for 128-bit atomics the
address under the lock is different from the original pointer.

This means that one of the values under the atomic operation is not protected
properly and so we fail during when the user has requested sequential
consistency as there's no barrier to enforce this requirement.

As such users have resorted to adding an

#ifdef GCC
<emit barrier>
#endif

around the use of these atomics.

This corrects the issue by issuing a barrier only when __ATOMIC_SEQ_CST was
requested.  I have hand verified that the barriers are inserted
for atomic seq cst.

libatomic/ChangeLog:

PR target/102218
* config/arm/host-config.h (pre_seq_barrier, post_seq_barrier,
pre_post_seq_barrier): Require barrier on __ATOMIC_SEQ_CST.
libatomic/config/arm/host-config.h
This page took 0.057921 seconds and 5 git commands to generate.