]> gcc.gnu.org Git - gcc.git/commit
OpenMP: Handle descriptors in target's firstprivate [PR104949]
authorTobias Burnus <tobias@codesourcery.com>
Mon, 23 May 2022 08:54:32 +0000 (10:54 +0200)
committerTobias Burnus <tobias@codesourcery.com>
Mon, 23 May 2022 08:54:32 +0000 (10:54 +0200)
commit49d1a2f91325fa8cc011149e27e5093a988b3a49
treece38d6f9032b9def8f22449dafc015b05fe4db6b
parent7707d7fddf7d6858399c8a47b139dc4708c5d7d9
OpenMP: Handle descriptors in target's firstprivate [PR104949]

For allocatable/pointer arrays, a firstprivate to a device
not only needs to privatize the descriptor but also the actual
data. This is implemented as:
  firstprivate(x) firstprivate(x.data) attach(x [bias: &x.data-&x)
where the address of x in device memory is saved in hostaddrs[i]
by libgomp and the middle end actually passes hostaddrs[i]' to
attach.

As side effect, has_device_addr(array_desc) had to be changed:
before, it was converted to firstprivate in the front end; now
it is handled in omp-low.cc as has_device_addr requires a shallow
firstprivate (not touching the data pointer) while the normal
firstprivate requires (now) a deep firstprivate.

gcc/fortran/ChangeLog:

PR fortran/104949
* f95-lang.cc (LANG_HOOKS_OMP_ARRAY_SIZE): Redefine.
* trans-openmp.cc (gfc_omp_array_size): New.
(gfc_trans_omp_variable_list): Never turn has_device_addr
to firstprivate.
* trans.h (gfc_omp_array_size): New.

gcc/ChangeLog:

PR fortran/104949
* langhooks-def.h (lhd_omp_array_size): New.
(LANG_HOOKS_OMP_ARRAY_SIZE): Define.
(LANG_HOOKS_DECLS): Add it.
* langhooks.cc (lhd_omp_array_size): New.
* langhooks.h (struct lang_hooks_for_decls): Add hook.
* omp-low.cc (scan_sharing_clauses, lower_omp_target):
Handle GOMP_MAP_FIRSTPRIVATE for array descriptors.

libgomp/ChangeLog:

PR fortran/104949
* target.c (gomp_map_vars_internal, copy_firstprivate_data):
Support attach for GOMP_MAP_FIRSTPRIVATE.
* testsuite/libgomp.fortran/target-firstprivate-1.f90: New test.
* testsuite/libgomp.fortran/target-firstprivate-2.f90: New test.
* testsuite/libgomp.fortran/target-firstprivate-3.f90: New test.
gcc/fortran/f95-lang.cc
gcc/fortran/trans-openmp.cc
gcc/fortran/trans.h
gcc/langhooks-def.h
gcc/langhooks.cc
gcc/langhooks.h
gcc/omp-low.cc
libgomp/target.c
libgomp/testsuite/libgomp.fortran/target-firstprivate-1.f90 [new file with mode: 0644]
libgomp/testsuite/libgomp.fortran/target-firstprivate-2.f90 [new file with mode: 0644]
libgomp/testsuite/libgomp.fortran/target-firstprivate-3.f90 [new file with mode: 0644]
This page took 0.062485 seconds and 5 git commands to generate.