]> gcc.gnu.org Git - gcc.git/commit
libgomp: Fix segfault with posthumous orphan tasks [PR104385]
authorJakub Jelinek <jakub@redhat.com>
Tue, 8 Feb 2022 08:30:17 +0000 (09:30 +0100)
committerJakub Jelinek <jakub@redhat.com>
Tue, 8 Feb 2022 08:30:17 +0000 (09:30 +0100)
commit0af7ef050aed9f678d70d79931ede38374fde863
treec105f2acc20ab08dd9dc3befad16e9c92512a7ee
parenta362158097352e9f2e4140d58a85ea3c0d95d3e4
libgomp: Fix segfault with posthumous orphan tasks [PR104385]

The following patch fixes crashes with posthumous orphan tasks.
When a parent task finishes, gomp_clear_parent clears the parent
pointers of its children tasks present in the parent->children_queue.
But children that are still waiting for dependencies aren't in that
queue yet, they will be added there only when the sibling they are
waiting for exits.  Unfortunately we were adding those tasks into
the queues with the original task->parent which then causes crashes
because that task is gone and freed.  The following patch fixes that
by clearing the parent field when we schedule such task for running
by adding it into the queues and we know that the sibling task which
is about to finish has NULL parent.

2022-02-08  Jakub Jelinek  <jakub@redhat.com>

PR libgomp/104385
* task.c (gomp_task_run_post_handle_dependers): If parent is NULL,
clear task->parent.
* testsuite/libgomp.c/pr104385.c: New test.
libgomp/task.c
libgomp/testsuite/libgomp.c/pr104385.c [new file with mode: 0644]
This page took 0.055241 seconds and 5 git commands to generate.