]> gcc.gnu.org Git - gcc.git/commit
libstdc++: Avoid aliasing violation in std::valarray [PR99117]
authorJonathan Wakely <jwakely@redhat.com>
Thu, 8 Feb 2024 13:59:42 +0000 (13:59 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Thu, 15 Feb 2024 11:43:21 +0000 (11:43 +0000)
commitb58f0e5216a3053486e7f1aa96c3f2443b14d630
tree753183dc3948c3f5338c7fe492915d8a72584bb1
parent4d6513f80bd2349559ec7e3844cf096cdb103e9a
libstdc++: Avoid aliasing violation in std::valarray [PR99117]

The call to __valarray_copy constructs an _Array object to refer to
this->_M_data but that means that accesses to this->_M_data are through
a restrict-qualified pointer. This leads to undefined behaviour when
copying from an _Expr object that actually aliases this->_M_data.

Replace the call to __valarray_copy with a plain loop. I think this
removes the only use of that overload of __valarray_copy, so it could
probably be removed. I haven't done that here.

libstdc++-v3/ChangeLog:

PR libstdc++/99117
* include/std/valarray (valarray::operator=(const _Expr&)):
Use loop to copy instead of __valarray_copy with _Array.
* testsuite/26_numerics/valarray/99117.cc: New test.
libstdc++-v3/include/std/valarray
libstdc++-v3/testsuite/26_numerics/valarray/99117.cc [new file with mode: 0644]
This page took 0.062872 seconds and 6 git commands to generate.