]> gcc.gnu.org Git - gcc.git/commit
tree-optimization/105198 - wrong code with predictive commoning
authorRichard Biener <rguenther@suse.de>
Fri, 8 Apr 2022 11:13:29 +0000 (13:13 +0200)
committerRichard Biener <rguenther@suse.de>
Fri, 6 May 2022 12:47:11 +0000 (14:47 +0200)
commit29e8fe04e707910b1bcf15cbc2b582ee0e0e93d6
tree4056e76c766e5953f2162f873548759e23ca3528
parentfa26d65dfb41e527bd0db3af3ec2a6ac052019f4
tree-optimization/105198 - wrong code with predictive commoning

When predictive commoning looks for a looparound PHI it tries
to match the entry value definition (a load) up with the appropriate
member of the chain.  But it fails to consider stmts clobbering
the very same memory location inbetween the load and loop entry.

In theory we could be more clever on must aliases that would be
also picked up from a load (so not exactly stmt_kills_ref_p) and
use the stored value from that if it is an exact match.  But we
currently have no way to propagate this information inside predcom.

2022-04-08  Richard Biener  <rguenther@suse.de>

PR tree-optimization/105198
* tree-predcom.c (find_looparound_phi): Check whether
the found memory location of the entry value is clobbered
inbetween the value we want to use and loop entry.

* gcc.dg/torture/pr105198.c: New testcase.

(cherry picked from commit e5453bcc217ea4ac53a4ac277661d6ef0ccd425b)
gcc/testsuite/gcc.dg/torture/pr105198.c [new file with mode: 0644]
gcc/tree-predcom.c
This page took 0.068885 seconds and 6 git commands to generate.