Bug 99866 - gcc/config/aarch64/aarch64-protos.h: 2 * passing structs ?
Summary: gcc/config/aarch64/aarch64-protos.h: 2 * passing structs ?
Status: RESOLVED WONTFIX
Alias: None
Product: gcc
Classification: Unclassified
Component: target (show other bugs)
Version: 11.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks: cppcheck
  Show dependency tree / graph
 
Reported: 2021-04-01 10:01 UTC by David Binderman
Modified: 2021-04-09 11:46 UTC (History)
2 users (show)

See Also:
Host:
Target: aarch64
Build:
Known to work:
Known to fail:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2021-04-01 10:01:11 UTC 
1.

gcc/config/aarch64/aarch64-protos.h:348:70: performance: Function parameter 'base' should be passed by const reference. [passedByValue]

Source code is

  constexpr aarch64_simd_vec_issue_info (aarch64_base_vec_issue_info base,
                                         unsigned int ld2_st2_general_ops,
                                         unsigned int ld3_st3_general_ops,
                                         unsigned int ld4_st4_general_ops)

2.

gcc/config/aarch64/aarch64-protos.h:377:34: performance: Function parameter 'base' should be passed by const reference. [passedByValue]

Duplicate.
Comment 1 Richard Sandiford 2021-04-09 11:46:45 UTC 
Thanks for the report.  These constructors are only used for
static data though, so I think we should keep them as-is.