Bug 98277 - d: ICE in gimplify_expr, at gimplify.c
Summary: d: ICE in gimplify_expr, at gimplify.c
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: d (show other bugs)
Version: 9.3.1
: P3 normal
Target Milestone: ---
Assignee: Iain Buclaw
URL:
Keywords: ice-on-valid-code
Depends on:
Blocks:
 
Reported: 2020-12-14 14:28 UTC by Iain Buclaw
Modified: 2020-12-15 21:28 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail: 10.1.0, 11.0, 9.3.0
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Iain Buclaw 2020-12-14 14:28:30 UTC
This happens when using an enum member in a ternary condition for a function that returns by reference.

---
enum Side
{
    left
}

int left;
int right;

ref int get(Side side)
{
    return side == Side.left ? left : right;
}
---
Comment 1 GCC Commits 2020-12-15 21:25:14 UTC
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:36c9a3fe3f3c200ad3937d00d339b7269cf07adb

commit r11-6099-g36c9a3fe3f3c200ad3937d00d339b7269cf07adb
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Tue Dec 15 10:36:00 2020 +0100

    d: Fix ICE in gimplify_expr, at gimplify.c (PR98277)
    
    The DMD front-end shouldn't, but can sometimes leak manifest constants
    in the AST passed to the code generator.  To prevent this being an
    issue, the setting of DECL_INITIAL has been moved to the point where the
    CONST_DECL is used, rather than in the declaration handler.
    
    gcc/d/ChangeLog:
    
            PR d/98277
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Move setting of
            DECL_INITIAL for manifest constants to ...
            (get_symbol_decl): ... here.
    
    gcc/testsuite/ChangeLog:
    
            PR d/98277
            * gdc.dg/pr98277.d: New test.
Comment 2 GCC Commits 2020-12-15 21:25:50 UTC
The releases/gcc-10 branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:d0bdf3a9069f8f42b2ab196db2c4d75937722646

commit r10-9154-gd0bdf3a9069f8f42b2ab196db2c4d75937722646
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Tue Dec 15 10:36:00 2020 +0100

    d: Fix ICE in gimplify_expr, at gimplify.c (PR98277)
    
    The DMD front-end shouldn't, but can sometimes leak manifest constants
    in the AST passed to the code generator.  To prevent this being an
    issue, the setting of DECL_INITIAL has been moved to the point where the
    CONST_DECL is used, rather than in the declaration handler.
    
    gcc/d/ChangeLog:
    
            PR d/98277
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Move setting of
            DECL_INITIAL for manifest constants to ...
            (get_symbol_decl): ... here.
    
    gcc/testsuite/ChangeLog:
    
            PR d/98277
            * gdc.dg/pr98277.d: New test.
    
    (cherry picked from commit 36c9a3fe3f3c200ad3937d00d339b7269cf07adb)
Comment 3 GCC Commits 2020-12-15 21:27:35 UTC
The releases/gcc-9 branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:85b55ae6e87bd5cf6a23175065f634614e96a243

commit r9-9116-g85b55ae6e87bd5cf6a23175065f634614e96a243
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Tue Dec 15 10:36:00 2020 +0100

    d: Fix ICE in gimplify_expr, at gimplify.c (PR98277)
    
    The DMD front-end shouldn't, but can sometimes leak manifest constants
    in the AST passed to the code generator.  To prevent this being an
    issue, the setting of DECL_INITIAL has been moved to the point where the
    CONST_DECL is used, rather than in the declaration handler.
    
    gcc/d/ChangeLog:
    
            PR d/98277
            * decl.cc (DeclVisitor::visit (VarDeclaration *)): Move setting of
            DECL_INITIAL for manifest constants to ...
            (get_symbol_decl): ... here.
    
    gcc/testsuite/ChangeLog:
    
            PR d/98277
            * gdc.dg/pr98277.d: New test.
    
    (cherry picked from commit 36c9a3fe3f3c200ad3937d00d339b7269cf07adb)
Comment 4 Iain Buclaw 2020-12-15 21:28:43 UTC
Fix committed.