Bug 98153 - [11 Regression] libgo ftbfs on i686-gnu
Summary: [11 Regression] libgo ftbfs on i686-gnu
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: go (show other bugs)
Version: 11.0
: P3 normal
Target Milestone: 11.0
Assignee: Ian Lance Taylor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 09:24 UTC by Matthias Klose
Modified: 2021-02-23 18:35 UTC (History)
3 users (show)

See Also:
Host:
Target: i686-gnu
Build:
Known to work: 10.2.1
Known to fail: 11.0
Last reconfirmed:

Attachments
Build fix of libgo for GNU/Hurd (1.21 KB, patch)
2020-12-07 22:06 UTC, Svante Signell 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Klose 2020-12-05 09:24:29 UTC 
trunk 20201204 ftbfs on i686-gnu:

../../../src/libgo/go/syscall/socket_bsd.go:97:25: error: reference to undefined name 'AF_LINK'
   97 |         sa.raw.Family = AF_LINK
      |                         ^
Makefile:2957: recipe for target 'syscall.lo' failed
make[6]: *** [syscall.lo] Error 1
make[6]: Leaving directory '/<<PKGBUILDDIR>>/build/i686-gnu/libgo'
Makefile:2287: recipe for target 'all-recursive' failed
make[5]: *** [all-recursive] Error 1
Comment 1 Svante Signell 2020-12-07 22:06:19 UTC 
Created attachment 49702 [details]
Build fix of libgo for GNU/Hurd
Comment 2 Svante Signell 2020-12-07 22:11:36 UTC 
Hello,

Looking into the build failure of libgo for GNU/Hurd reveals that since AF_LINK is not yet supported, the corresponding code for SockaddrDatalink stuff needs to be stripped off socket_bsd.go, thereby creating socket_hurd.go. This is reflected in the attached patch.

Thanks!
Comment 3 GCC Commits 2020-12-08 01:08:57 UTC 
The master branch has been updated by Ian Lance Taylor <ian@gcc.gnu.org>:

https://gcc.gnu.org/g:9121f8084162ff6193a5e941cab1429e4180997a

commit r11-5834-g9121f8084162ff6193a5e941cab1429e4180997a
Author: Ian Lance Taylor <iant@golang.org>
Date:   Mon Dec 7 15:25:43 2020 -0800

    syscall: don't use AF_LINK on hurd
    
    Patch from Svante Signell.
    
    Fixes PR go/98153
    
    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/275939
Comment 4 Ian Lance Taylor 2020-12-08 01:10:49 UTC 
Thanks.  Patch committed.