cpuid.h has /* XFEATURE_ENABLED_MASK register bits (%eax == 13, %ecx == 0) */ ^^^ This is decimal. /* Extended State Enumeration Sub-leaf (%eax == 13, %ecx == 1) */ ^^^ This is decimal. /* PT sub leaf (%eax == 14, %ecx == 0) */ ^^^ This is hex. Since Intel SDM uses hex, comments should use hex eveywhere.
Just a question: why do you create PRs for all these issues? Is it because you want to backport fixes to active branches?
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:a74630f3207d0bec63710c8c803685a0a4956986 commit r11-552-ga74630f3207d0bec63710c8c803685a0a4956986 Author: H.J. Lu <hjl.tools@gmail.com> Date: Thu May 21 07:19:27 2020 -0700 config/i386/cpuid.h: Use hexadecimal in comments Since Intel SDM uses hexadecimal, use hexadecimal in comments. PR target/95260 * config/i386/cpuid.h: Use hexadecimal in comments.
Fixed for GCC 11.
(In reply to Martin Liška from comment #1) > Just a question: why do you create PRs for all these issues? > Is it because you want to backport fixes to active branches? That would be nice.