The SUSE SPECint2000 continuous regression tester shows a ~8% runtime regression on Haswell around the beginning of February 2019. [1] https://gcc.opensuse.org/gcc-old/SPEC/CINT/sb-czerny-head-64/252_eon_big.png
Last known good r268430, first known bad r268456. Note it's a regression during GCC 9 development so compared to GCC 8 it's not a regression.
As expected it regressed with r268448 which dropped max-inline-insns-single from 400 to 200. Honza should remember what was importrant to optimize here (but certainly SPEC 2000 ceased to be relevant). 5.93% 9002 eon_base.none eon_base.none [.] mrGrid::viewingHit 5.57% 8478 eon_base.none eon_base.none [.] mrSurfaceList::viewingHit 5.50% 8296 eon_peak.none eon_peak.none [.] mrSurfaceList::viewingHit 5.17% 7789 eon_peak.none eon_peak.none [.] ggGridIterator<mrSurface*>::ggGridIterato 4.34% 6533 eon_peak.none eon_peak.none [.] mrGrid::viewingHit 4.18% 6332 eon_base.none eon_base.none [.] mrGrid::shadowHit 3.26% 4908 eon_peak.none eon_peak.none [.] mrGrid::shadowHit suggests that inlining ggGridIterator is important and missing now, likely into viewingHit.
Has anyone relooked into this? There has been many inlining changes since GCC 9 even.