Bug 90874 - trunk/gcc/ipa-utils.h:243: possible cut-n-paste error ?
Summary: trunk/gcc/ipa-utils.h:243: possible cut-n-paste error ?
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: ipa (show other bugs)
Version: 10.0
: P3 normal
Target Milestone: 10.0
Assignee: Martin Liška
URL:
Keywords:
Depends on:
Blocks: cppcheck
  Show dependency treegraph
 
Reported: 2019-06-13 18:38 UTC by David Binderman
Modified: 2019-06-17 09:04 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2019-06-17 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2019-06-13 18:38:35 UTC
trunk/gcc/ipa-utils.h:243]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.

svn blame says

272037    hubicka   return TYPE_NAME (t) && TREE_CODE (TYPE_NAME (t)) == TYPE_DECL
272037    hubicka          && DECL_ASSEMBLER_NAME_SET_P (TYPE_NAME (t));
231098    hubicka   return false;
Comment 1 Eric Gallager 2019-06-13 19:19:36 UTC
This is cppcheck, right? Assuming so...
Comment 2 Martin Liška 2019-06-17 06:45:19 UTC
Let me fix it.
Comment 3 Martin Liška 2019-06-17 09:03:57 UTC
Author: marxin
Date: Mon Jun 17 09:03:26 2019
New Revision: 272378

URL: https://gcc.gnu.org/viewcvs?rev=272378&root=gcc&view=rev
Log:
Remove dead code (PR ipa/90874).

2019-06-17  Martin Liska  <mliska@suse.cz>

	PR ipa/90874
	* ipa-utils.h (odr_type_p): Remove dead code.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-utils.h
Comment 4 Martin Liška 2019-06-17 09:04:22 UTC
Fixed.