In the patch to add destroying_delete, (Implement P0722R3, destroying operator delete.) the constexpr token is used directly, can you modify this to use the macro e.g. _GLIBCXX_CONSTEXPR. For example, recently the clang compiler predefines __cpp_impl_destroying_delete and this causes the <new> header to fail compilation if compiling with option -std=c++98.
This issue is discussed here, https://reviews.llvm.org/D55741
Thanks and regards
(I work on the Intel C++ compiler)
I already started fixing this after your update to the phabricator update pinged me an email. I'm just going to make it conditional on __cplusplus > 201703L.
Date: Wed Feb 13 22:13:45 2019
New Revision: 268856
PR libstdc++/89345 Only define std::destroying_delete for C++2a
Clang defines the __cpp_impl_destroying_delete macro unconditionally, so
that the feature is supported whenever the library type is defined. This
is incompatible with the current definition in libstdc++ because we use
constexpr and inline variables, which will give an error for older -std
This patch defines the destroying_delete_t type and destroying_delete
variable independently of the __cpp_impl_destroying_delete macro, but
only for C++2a (because the names aren't reserved for previous
standards). The __cpp_lib_destroying_delete macro is only defined when
both the library type and compiler macro are defined (i.e. when the type
can actually be used as intended).
* include/std/version [__cpp_impl_destroying_delete]
(__cpp_lib_destroying_delete): Only define for C++2a and later.
* libsupc++/new [__cpp_impl_destroying_delete]
(destroying_delete_t, destroying_delete): Likewise, but define even
when __cpp_impl_destroying_delete is not defined.
* testsuite/18_support/destroying_delete.cc: New test.