Bug 86981 - Add Clang's -Wpessimizing-move warning
Summary: Add Clang's -Wpessimizing-move warning
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c++ (show other bugs)
Version: 9.0
: P3 enhancement
Target Milestone: ---
Assignee: Marek Polacek
URL:
Keywords: diagnostic
Depends on:
Blocks:
 
Reported: 2018-08-16 15:04 UTC by Jonathan Wakely
Modified: 2023-12-30 02:22 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2018-08-16 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wakely 2018-08-16 15:04:31 UTC
#include <utility>

struct T {
  T() { }
  T(const T&) { }
  T(T&&) { }
};

T f() {
  T t;
  return std::move(t);
}

Clang warns about this:

m.cc:5:21: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
T f() { T t; return std::move(t); }
                    ^
m.cc:5:21: note: remove std::move call here
T f() { T t; return std::move(t); }
                    ^~~~~~~~~~ ~
1 warning generated.
Comment 1 Marek Polacek 2018-08-21 15:39:08 UTC
Author: mpolacek
Date: Tue Aug 21 15:38:36 2018
New Revision: 263741

URL: https://gcc.gnu.org/viewcvs?rev=263741&root=gcc&view=rev
Log:
	PR c++/86981, Implement -Wpessimizing-move.
	* c.opt (Wpessimizing-move): New option.

	* typeck.c (decl_in_std_namespace_p): New.
	(is_std_move_p): New.
	(maybe_warn_pessimizing_move): New.
	(can_do_nrvo_p): New, factored out of ...
	(check_return_expr): ... here.  Warn about potentially harmful
	std::move in a return statement.

	* doc/invoke.texi: Document -Wpessimizing-move.

	* g++.dg/cpp0x/Wpessimizing-move1.C: New test.
	* g++.dg/cpp0x/Wpessimizing-move2.C: New test.
	* g++.dg/cpp0x/Wpessimizing-move3.C: New test.
	* g++.dg/cpp0x/Wpessimizing-move4.C: New test.
	* g++.dg/cpp1z/Wpessimizing-move1.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/Wpessimizing-move1.C
    trunk/gcc/testsuite/g++.dg/cpp0x/Wpessimizing-move2.C
    trunk/gcc/testsuite/g++.dg/cpp0x/Wpessimizing-move3.C
    trunk/gcc/testsuite/g++.dg/cpp0x/Wpessimizing-move4.C
    trunk/gcc/testsuite/g++.dg/cpp1z/Wpessimizing-move1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c.opt
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/doc/invoke.texi
    trunk/gcc/testsuite/ChangeLog
Comment 2 Marek Polacek 2018-08-21 15:39:47 UTC
Done for GCC 9.