Bug 85411 - [openacc] Move GOMP_OPENACC_DIM parsing out of nvptx plugin
Summary: [openacc] Move GOMP_OPENACC_DIM parsing out of nvptx plugin
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: libgomp (show other bugs)
Version: 8.0
: P3 trivial
Target Milestone: 9.0
Assignee: Not yet assigned to anyone
URL:
Keywords: openacc, patch
Depends on:
Blocks:
 
Reported: 2018-04-16 09:23 UTC by Tom de Vries
Modified: 2018-05-02 17:55 UTC (History)
2 users (show)

See Also:
Host:
Target: nvptx
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2018-04-16 09:23:15 UTC
As mentioned here ( https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01020.html ):
...
the GOMP_OPENACC_DIM parsing conceptually belongs into generic libgomp code, instead of the nvptx plugin.  (But that aspect can be cleaned up later: currently, the nvptx plugin is the only one supporting/using it.)
...

[ And re-iterated here: PR85129 comment 3 ]
Comment 2 Tom de Vries 2018-05-02 17:54:28 UTC
Author: vries
Date: Wed May  2 17:53:56 2018
New Revision: 259852

URL: https://gcc.gnu.org/viewcvs?rev=259852&root=gcc&view=rev
Log:
[openacc] Move GOMP_OPENACC_DIM parsing out of nvptx plugin

2018-05-02  Tom de Vries  <tom@codesourcery.com>

	PR libgomp/85411
	* plugin/plugin-nvptx.c (nvptx_exec): Move parsing of
	GOMP_OPENACC_DIM ...
	* env.c (parse_gomp_openacc_dim): ... here.  New function.
	(initialize_env): Call parse_gomp_openacc_dim.
	(goacc_default_dims): Define.
	* libgomp.h (goacc_default_dims): Declare.
	* oacc-plugin.c (GOMP_PLUGIN_acc_default_dim): New function.
	* oacc-plugin.h (GOMP_PLUGIN_acc_default_dim): Declare.
	* libgomp.map: New version "GOMP_PLUGIN_1.2". Add
	GOMP_PLUGIN_acc_default_dim.
	* testsuite/libgomp.oacc-c-c++-common/loop-default-runtime.c: New test.
	* testsuite/libgomp.oacc-c-c++-common/loop-default.h: New test.

Added:
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-default-runtime.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-default.h
Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/env.c
    trunk/libgomp/libgomp.h
    trunk/libgomp/libgomp.map
    trunk/libgomp/oacc-plugin.c
    trunk/libgomp/oacc-plugin.h
    trunk/libgomp/plugin/plugin-nvptx.c
Comment 3 Tom de Vries 2018-05-02 17:55:14 UTC
Patch with test-cases committed, marking resolved-fixed.