Bug 81670 - include/ext/pb_ds/detail/splay_tree_/splay_fn_imps.hpp:253: suspicious assignment ?
Summary: include/ext/pb_ds/detail/splay_tree_/splay_fn_imps.hpp:253: suspicious assign...
Status: NEW
Alias: None
Product: gcc
Classification: Unclassified
Component: libstdc++ (show other bugs)
Version: 7.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks: cppcheck
  Show dependency tree / graph
 
Reported: 2017-08-02 13:06 UTC by David Binderman
Modified: 2021-11-06 07:34 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2018-02-28 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2017-08-02 13:06:14 UTC 
trunk/libstdc++-v3/include/ext/pb_ds/detail/splay_tree_/splay_fn_imps.hpp:253]: (warning) Redundant assignment of 'base_type::m_p_head->m_p_parent' to itself.

Source code is

  if (grandparent_head)
    {
      base_type::m_p_head->m_p_parent = base_type::m_p_head->m_p_parent;
Comment 1 David Binderman 2018-02-12 12:03:19 UTC 
Still broken six months later.
Comment 2 Jonathan Wakely 2018-02-12 13:07:40 UTC 
What's broken? Is there an actual bug or just a redundant assignment?

(I'm unaware of anybody anywhere ever using these containers so it's hardly a priority)
Comment 3 Eric Gallager 2019-06-28 08:03:02 UTC 
(In reply to Jonathan Wakely from comment #2)
> What's broken? Is there an actual bug or just a redundant assignment?
> 
> (I'm unaware of anybody anywhere ever using these containers so it's hardly
> a priority)

You said you were thinking about removing them, right?
Comment 4 Jonathan Wakely 2019-07-01 08:21:15 UTC 
Right, see https://gcc.gnu.org/ml/libstdc++/2019-05/msg00107.html