Bug 39408 – gjavah doesn't generate constants in header files where they occur in a superclass

Bug 39408 - gjavah doesn't generate constants in header files where they occur in a superclass


Summary:	gjavah doesn't generate constants in header files where they occur in a super...

Status:	RESOLVED FIXED

Product:	classpath
Classification:	Unclassified
Component:	cp-tools
Version:	0.98

Importance:	P3 normal
Target Milestone:	0.99
Assigned To:	Andrew John Hughes

URL:
Keywords:

Depends on:
Blocks:	39410
	Show dependency tree / graph

Reported:	2009-03-09 14:33 UTC by Andrew John Hughes
Modified:	2010-10-12 17:28 UTC (History)
CC List:	1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:	2009-03-16 23:53:57

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew John Hughes 2009-03-09 14:33:21 UTC

In OpenJDK[7] b50:

../../../src/solaris/native/sun/nio/ch/FileDispatcherImpl.c: In function 'Java_sun_nio_ch_FileDispatcherImpl_lock0':
../../../src/solaris/native/sun/nio/ch/FileDispatcherImpl.c:195: error: 'sun_nio_ch_FileDispatcherImpl_NO_LOCK' undeclared (first use in this function)
../../../src/solaris/native/sun/nio/ch/FileDispatcherImpl.c:195: error: (Each undeclared identifier is reported only once
../../../src/solaris/native/sun/nio/ch/FileDispatcherImpl.c:195: error: for each function it appears in.)
../../../src/solaris/native/sun/nio/ch/FileDispatcherImpl.c:197: error: 'sun_nio_ch_FileDispatcherImpl_INTERRUPTED' undeclared (first use in this function)

NO_LOCK and INTERRUPTED are not declared in FileDispatcherImpl, but in FileDispatcher.

Comment 1 Andrew John Hughes 2009-03-16 23:53:57 UTC

 diff -u sun_nio_ch_FileDispatcherImpl.h{.old,}
--- sun_nio_ch_FileDispatcherImpl.h.old	2009-03-13 18:40:49.000000000 +0000
+++ sun_nio_ch_FileDispatcherImpl.h	2009-03-16 23:38:01.000000000 +0000
@@ -7,6 +7,14 @@
 #ifdef __cplusplus
 extern "C" {
 #endif
+#undef sun_nio_ch_FileDispatcherImpl_NO_LOCK
+#define sun_nio_ch_FileDispatcherImpl_NO_LOCK -1L
+#undef sun_nio_ch_FileDispatcherImpl_LOCKED
+#define sun_nio_ch_FileDispatcherImpl_LOCKED 0L
+#undef sun_nio_ch_FileDispatcherImpl_RET_EX_LOCK
+#define sun_nio_ch_FileDispatcherImpl_RET_EX_LOCK 1L
+#undef sun_nio_ch_FileDispatcherImpl_INTERRUPTED
+#define sun_nio_ch_FileDispatcherImpl_INTERRUPTED 2L
 /*
  * Class:     sun_nio_ch_FileDispatcherImpl
  * Method:    read0

Comment 2 Andrew John Hughes 2009-03-25 12:25:39 UTC

Bug fixed.  linkSupers() was never called before the search for eligible fields was made.

Comment 3 Andrew John Hughes 2010-10-12 17:28:16 UTC

Merged to gcj in libgcj-snapshot-20100921.