User account creation filtered due to spam.

Bug 33811 - Character assignment misses dependency
Summary: Character assignment misses dependency
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: fortran (show other bugs)
Version: 4.3.0
: P3 normal
Target Milestone: ---
Assignee: Paul Thomas
URL:
Keywords: wrong-code
Depends on: 31217
Blocks: 32834
  Show dependency treegraph
 
Reported: 2007-10-18 12:02 UTC by Paul Thomas
Modified: 2007-10-29 14:15 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2007-10-18 12:23:19


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Thomas 2007-10-18 12:02:34 UTC
This
$ cat assign_bug_3.f90
  character(1) :: a(3) = ['1','2','3']
  integer :: i = 1
  a(2:3)(i:i) = a(1:2)(i:i)
  print *, a
end

$ /irun/bin/gfortran assign_bug_3.f90; ./a
 111

is the wrong result (should be 112)

The problem lies in gfc_check_dependency, where the assumption about substrings is wrong.  Fixing this exposes an ICE in trans-array.c(gfc_trans_create_temp_array), which arises because the temporary is an incomplete type.

These problems are related to PR31217 and arose in the course of fixing that pr.

A fix for both will be posted tonight, as long as the regtesting completes OK.

Cheers

Paul
Comment 1 Paul Thomas 2007-10-18 14:50:42 UTC
(In reply to comment #0)

> A fix for both will be posted tonight, as long as the regtesting completes OK.
> Cheers
> Paul

This fix has been posted: http://gcc.gnu.org/ml/fortran/2007-10/msg00264.html

Paul
Comment 2 Tobias Burnus 2007-10-29 14:14:06 UTC
Subject: Bug 33811

Author: burnus
Date: Mon Oct 29 14:13:44 2007
New Revision: 129720

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=129720
Log:
2007-10-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/31217
        PR fortran/33811
        PR fortran/33686
        * trans-array.c (gfc_conv_loop_setup): Send a complete type to
        gfc_trans_create_temp_array if the temporary is character.
        * trans-stmt.c (gfc_trans_assign_need_temp): Do likewise for
        allocate_temp_for_forall_nest.
        (forall_replace): New function.
        (forall_replace_symtree): New function.
        (forall_restore): New function.
        (forall_restore_symtree): New function.
        (forall_make_variable_temp): New function.
        (check_forall_dependencies): New function.
        (cleanup_forall_symtrees): New function.
        gfc_trans_forall_1): Add and initialize pre and post blocks.
        Call check_forall_dependencies to check for all dependencies
        and either trigger second forall block to copy temporary or
        copy lval, outside the forall construct and replace all
        dependent references. After assignment clean-up and coalesce
        the blocks at the end of the function.
        * gfortran.h : Add prototypes for gfc_traverse_expr and
        find_forall_index.
        expr.c (gfc_traverse_expr): New function to traverse expression
        and visit all subexpressions, under control of a logical flag,
        a symbol and an integer pointer. The slave function is caller
        defined and is only called on EXPR_VARIABLE.
        (expr_set_symbols_referenced): Called by above to set symbols
        referenced.
        (gfc_expr_set_symbols_referenced): Rework of this function to
        use two new functions above.
        * resolve.c (find_forall_index): Rework with gfc_traverse_expr,
        using forall_index.
        (forall_index): New function used by previous.
        * dependency.c (gfc_check_dependency): Use gfc_dep_resolver for
        all references, not just REF_ARRAY.
        (gfc_dep_resolver): Correct the logic for substrings so that
        overlapping arrays are handled correctly.

2007-10-29 Paul Thomas <pault@gcc.gnu.org>

        PR fortran/31217
        PR fortran/33811
        * gfortran.dg/forall_12.f90: New test.

        PR fortran/33686
        * gfortran.dg/forall_13.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/forall_12.f90
    trunk/gcc/testsuite/gfortran.dg/forall_13.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/dependency.c
    trunk/gcc/fortran/expr.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/testsuite/ChangeLog

Comment 3 Tobias Burnus 2007-10-29 14:15:04 UTC
FIXED on the trunk (GCC 4.3.0).