Bug 33787 - remove globals from c-format.c
Summary: remove globals from c-format.c
Status: RESOLVED INVALID
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 4.3.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords: patch
Depends on:
Blocks: 4.4pending
  Show dependency treegraph
 
Reported: 2007-10-15 19:58 UTC by Tom Tromey
Modified: 2009-02-06 19:24 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2007-10-15 22:35:53


Attachments
remove globals from c-format.c (2.96 KB, patch)
2007-10-15 19:59 UTC, Tom Tromey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2007-10-15 19:58:31 UTC
This patch moves some globals in c-format.c into a structure.
It was bootstrapped and regtested on x86 FC 6

2007-10-12  Tom Tromey  <tromey@redhat.com>

	* c-format.c (dollar_argument_info): New struct.
	(dollar_arguments_used, dollar_arguments_pointer_p,
	dollar_arguments_alloc, dollar_arguments_count,
	dollar_first_arg_num, dollar_max_arg_used, dollar_format_warned):
	Remove.
	(init_dollar_format_checking): Add 'state' argument.
	(maybe_read_dollar_number): Likewise.
	(finish_dollar_format_checking): Likewise.
	(check_format_info_inner): Likewise.  Renamed from
	check_format_info_main.
	(check_format_info_main): New function.
Comment 1 Tom Tromey 2007-10-15 19:59:20 UTC
Created attachment 14355 [details]
remove globals from c-format.c
Comment 2 Andrew Pinski 2007-10-15 22:35:53 UTC
Confirmed.
Comment 3 Manuel López-Ibáñez 2008-08-13 10:28:57 UTC
@Tom

It would be nice to submit this patch before stage3.
Comment 4 Tom Tromey 2008-09-19 21:38:48 UTC
FWIW -- I think this patch turned out to have some GC-related bug.
And, I don't think I need this for the incremental branch either, any more.
So, I'm just dropping it and closing this.
If someone else wants to clean it up, that is fine by me.