Bug 27723 - Allow firefox-plugin to be used as mozilla-plugin
Summary: Allow firefox-plugin to be used as mozilla-plugin
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: classpath (show other bugs)
Version: 0.92
: P3 normal
Target Milestone: 0.92
Assignee: Thomas Fitzsimmons
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-22 16:30 UTC by schmir11
Modified: 2006-08-14 20:34 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2006-06-01 14:29:38


Attachments
Applies the suggested changes (256 bytes, patch)
2006-06-01 15:11 UTC, schmir11
Details | Diff
Applies the suggested changes (408 bytes, patch)
2006-06-01 15:51 UTC, schmir11
Details | Diff
seamonkey-plugin-detection.patch (268 bytes, patch)
2006-08-13 12:21 UTC, Lars (Polynomial-C)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description schmir11 2006-05-22 16:30:53 UTC
A change in configure.ac allows a fallback to the firefox-plugin if the mozilla-plugin is not available.

Here is the line of the original configure.ac that gets replaced.
You can find it in line 473:

PKG_CHECK_MODULES(MOZILLA, mozilla-plugin)


This is the replacement i suggest:

PKG_CHECK_MODULES(MOZILLA, mozilla-plugin,
  [MOZILLA_FOUND=yes],[MOZILLA_FOUND=no])

if test "x${MOZILLA_FOUND}" = xno; then
  PKG_CHECK_MODULES(MOZILLA, firefox-plugin,
    [MOZILLA_FOUND=yes], [MOZILLA_FOUND=no])
fi


Hint for locating the right place - this comment is
just 2 lines above the line to replace:
dnl Check for plugin support headers and libraries.
Comment 1 schmir11 2006-05-22 16:53:49 UTC
Just after submitting someone notified to check for the "xulrunner-plugin", too. 
So here is the modified code to do just that:


PKG_CHECK_MODULES(MOZILLA, mozilla-plugin,[MOZILLA_FOUND=yes],[MOZILLA_FOUND=no])

if test "x${MOZILLA_FOUND}" = xno; then
 PKG_CHECK_MODULES(MOZILLA, firefox-plugin,[MOZILLA_FOUND=yes], [MOZILLA_FOUND=no])
fi

if test "x${MOZILLA_FOUND}" = xno; then
 PKG_CHECK_MODULES(MOZILLA, xulrunner-plugin,[MOZILLA_FOUND=yes], [MOZILLA_FOUND=no])
fi
Comment 2 schmir11 2006-06-01 15:11:37 UTC
Created attachment 11568 [details]
Applies the suggested changes
Comment 3 schmir11 2006-06-01 15:51:46 UTC
Created attachment 11570 [details]
Applies the suggested changes

now the diff has the right format (unified output)
Comment 4 David Walluck 2006-07-31 01:27:48 UTC
In Mandriva, they use mozilla-firefox-plugin instead of firefox-plugin. Please add support for this as well.
Comment 5 Thomas Fitzsimmons 2006-08-02 19:35:50 UTC
I added the requested Mandriva support to GNU Classpath CVS HEAD.  Closing.

Comment 6 Lars (Polynomial-C) 2006-08-13 12:21:57 UTC
Created attachment 12072 [details]
seamonkey-plugin-detection.patch

Hi,

could you please incorporate this patch as well?
It fixes detection of http://www.mozilla.org/projects/seamonkey/ the successor of the no longer maintained mozilla-suite.

Thanx
Poly-C
Comment 7 Thomas Fitzsimmons 2006-08-14 20:34:07 UTC
(In reply to comment #6)
> Created an attachment (id=12072) [edit]
> seamonkey-plugin-detection.patch
> 
> Hi,
> 
> could you please incorporate this patch as well?
> It fixes detection of http://www.mozilla.org/projects/seamonkey/ the successor
> of the no longer maintained mozilla-suite.

Done.