Since testsuite/lib/libstdc++.exp just copies over $srcdir/data/*.t[sx]t (which in TCL appearantly implies copying permissions [but not owner/group]), the files may all end up non-writable if the source tree was set so. I'd suggest --- /usr/local/src/gcc-3.4.0/libstdc++-v3/testsuite/lib/libstdc++.exp 2004-03-18 18:38:09.000000000 +0100 +++ 3.4.0/libstdc++-v3/testsuite/lib/libstdc++.exp 2004-05-14 13:42:44.000000000 +0200 @@ -71,6 +71,8 @@ file copy -force $dirname/$symlink $dstdir } } + set basename [file tail $f] + file attributes $dstdir/$basename -permissions a+w } }
Same with this. Send it in as a patch: it looks like it may indeed be a bug, depending on how the originating sources are assigned permissions. -benjamin
Subject: Bug 15488 CVSROOT: /cvs/gcc Module name: gcc Changes by: bkoz@gcc.gnu.org 2004-05-18 18:42:28 Modified files: libstdc++-v3 : ChangeLog libstdc++-v3/scripts: create_testsuite_files libstdc++-v3/testsuite/lib: libstdc++.exp Log message: 2004-05-18 Jan Beulich <jbeulich@novell.com> PR libstdc++/15489 * scripts/create_testsuite_files: Also find source files through symbolic links. 2004-05-18 Jan Beulich <jbeulich@novell.com> PR libstdc++/15488 * testsuite/lib/libstdc++.exp: Make test files writable. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2482&r2=1.2483 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/scripts/create_testsuite_files.diff?cvsroot=gcc&r1=1.1&r2=1.2 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp.diff?cvsroot=gcc&r1=1.20&r2=1.21
Subject: Bug 15488 CVSROOT: /cvs/gcc Module name: gcc Branch: gcc-3_4-branch Changes by: bkoz@gcc.gnu.org 2004-05-19 23:36:39 Modified files: libstdc++-v3 : ChangeLog libstdc++-v3/scripts: create_testsuite_files libstdc++-v3/testsuite/lib: libstdc++.exp Log message: 2004-05-19 Jan Beulich <jbeulich@novell.com> PR libstdc++/15489 * scripts/create_testsuite_files: Also find source files through symbolic links. 2004-05-19 Jan Beulich <jbeulich@novell.com> PR libstdc++/15488 * testsuite/lib/libstdc++.exp: Make test files writable. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2224.2.108&r2=1.2224.2.109 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/scripts/create_testsuite_files.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1&r2=1.1.22.1 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.15.4.3&r2=1.15.4.4
Fixed.
This isn't really fixed. The change to use remote_download in v3-copy-files made this patch unnecessary, and the way it was applied it actually became counter-productive since other than the submitted patch the one applied changes the mode of the source files (in the source tree, that is) rather than that of the destination files. If the user running the testsuite doesn't have sufficient rights to do so, the whole testsuite run now fails. In the light of all that, the patch simply needs to be backed out in both mainline and 3_4-branch.
Subject: Bug 15488 CVSROOT: /cvs/gcc Module name: gcc Changes by: bkoz@gcc.gnu.org 2004-07-19 23:11:03 Modified files: libstdc++-v3 : ChangeLog libstdc++-v3/testsuite/lib: libstdc++.exp Log message: 2004-07-19 Benjamin Kosnik <bkoz@redhat.com> PR libstdc++/15488 * testsuite/lib/libstdc++.exp (v3-copy-files): Revert. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2580&r2=1.2581 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp.diff?cvsroot=gcc&r1=1.21&r2=1.22
I'm reverting this patch on both branches: PR libstdc++/15488 -benjamin
Subject: Bug 15488 CVSROOT: /cvs/gcc Module name: gcc Branch: gcc-3_4-branch Changes by: bkoz@gcc.gnu.org 2004-07-19 23:35:37 Modified files: libstdc++-v3 : ChangeLog libstdc++-v3/testsuite/lib: libstdc++.exp Log message: 2004-07-19 Benjamin Kosnik <bkoz@redhat.com> PR libstdc++/15488 * testsuite/lib/libstdc++.exp (v3-copy-files): Revert. Patches: http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2224.2.146&r2=1.2224.2.147 http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.15.4.4&r2=1.15.4.5
Can I close this?
I believe so.
So closing as fixed.