Bug 115288 - [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668
Summary: [15 Regression] File label-text.h not part of installation since r15-874-g9bd...
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: plugins (show other bugs)
Version: 15.0
: P3 normal
Target Milestone: 15.0
Assignee: Andrew Pinski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-30 07:12 UTC by David Binderman
Modified: 2024-06-06 17:46 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2024-05-30 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2024-05-30 07:12:55 UTC 
I have just tried a linux kernel build with this morning's gcc trunk compiler
and I got this:

home/dcb40b/gcc/results.20240530.asan.ubsan/lib/gcc/x86_64-pc-linux-gnu/15.0.0/plugin/include/rich-location.h:25:10: fatal error: label-text.h: No such file or directory
   25 | #include "label-text.h"
      |          ^~~~~~~~~~~~~~

Doing this 

$ cp /home/dcb40b/gcc/trunk.20210101/libcpp/include/label-text.h /home/dcb40b/gcc/results.20240530.asan.ubsan/bin/../lib/gcc/x86_64-pc-linux-gnu/15.0.0/plugin/include/
$ 

seems to solve the problem. 

It looks to me like someone forgot to add file label-text.h to some list 
in the install make target.
Comment 1 Andrew Pinski 2024-05-30 14:54:25 UTC 
I think this fixes the issue (which was introduced by r15-874-g9bda2c4c81b668 ):
```
[apinski@xeond2 gcc]$ git diff Makefile.in
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 66d42cc41f8..67c00a9c23f 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1038,6 +1038,7 @@ SYSTEM_H = system.h hwint.h $(srcdir)/../include/libiberty.h \
 PREDICT_H = predict.h predict.def
 CPPLIB_H = $(srcdir)/../libcpp/include/line-map.h \
        $(srcdir)/../libcpp/include/rich-location.h \
+       $(srcdir)/../libcpp/include/label-text.h \
        $(srcdir)/../libcpp/include/cpplib.h
 CODYLIB_H = $(srcdir)/../libcody/cody.hh
 INPUT_H = $(srcdir)/../libcpp/include/line-map.h input.h
```

Let me double check that and commit as obvious if it works.
Comment 2 GCC Commits 2024-06-06 17:04:45 UTC 
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:6e6471806d886bc052d3922d636d49aaf75d5d16

commit r15-1076-g6e6471806d886bc052d3922d636d49aaf75d5d16
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu May 30 07:59:00 2024 -0700

    Plugins: Add label-text.h to CPPLIB_H so it will be installed [PR115288]
    
    After r15-874-g9bda2c4c81b668, out of tree plugins won't compile
    as the new libcpp header file label-text.h is not installed.
    
    This adds the new header file to CPPLIB_H which is used for
    the plugin headers to install.
    
    Committed as obvious after a build and install and make sure
    the new header file is installed.
    
    gcc/ChangeLog:
    
            PR plugins/115288
            * Makefile.in (CPPLIB_H): Add label-text.h.
    
    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
Comment 3 Sam James 2024-06-06 17:05:26 UTC 
I should've said, the obvious patch did indeed work for me.
Comment 4 Andrew Pinski 2024-06-06 17:05:37 UTC 
Fixed.
Comment 5 David Malcolm 2024-06-06 17:46:54 UTC 
Sorry about the breakage; thanks for fixing this