Bug 113931 - [14 regression] 26_numerics/random/pr60037-neg.cc fails after r14-8998-gc9ce332b557bb9
Summary: [14 regression] 26_numerics/random/pr60037-neg.cc fails after r14-8998-gc9ce3...
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: libstdc++ (show other bugs)
Version: 14.0
: P3 normal
Target Milestone: 14.0
Assignee: Jonathan Wakely
URL:
Keywords: testsuite-fail
Depends on:
Blocks:
 
Reported: 2024-02-15 17:16 UTC by seurer
Modified: 2024-02-16 11:48 UTC (History)
5 users (show)

See Also:
Host: powerpc64le-linux-gnu
Target: powerpc64le-linux-gnu aarch64-linux-gnu
Build: powerpc64le-linux-gnu
Known to work:
Known to fail:
Last reconfirmed: 2024-02-15 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description seurer 2024-02-15 17:16:01 UTC 
g:c9ce332b557bb95987d038d98ea929cdfd1eae1d, r14-8998-gc9ce332b557bb9
make  -k check RUNTESTFLAGS="conformance.exp=26_numerics/random/pr60037-neg.cc"
FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17  (test for errors, line 271)
FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17 (test for excess errors)
# of expected passes		1
# of unexpected failures	2


FAIL: 26_numerics/random/pr60037-neg.cc  -std=gnu++17 (test for excess errors)
Excess errors:
/home/seurer/gcc/git/build/gcc-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/include/bits/random.h:270: error: static assertion failed: template argument must be a floating point type


commit c9ce332b557bb95987d038d98ea929cdfd1eae1d (HEAD)
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 7 11:31:10 2024 +0000

    libstdc++: Use 128-bit arithmetic for std::linear_congruential_engine [PR87744]
Comment 1 Jakub Jelinek 2024-02-15 17:43:05 UTC 
The first line of the static_assert is indeed line 270 rather than 271.
Comment 2 Jonathan Wakely 2024-02-15 17:46:23 UTC 
Doh - that's what I get for only rerunning a subset of tests after removing a line.
Comment 3 Jonathan Wakely 2024-02-15 17:46:58 UTC 
Oh but I did rerun that one and still missed the FAIL.
Comment 4 GCC Commits 2024-02-16 10:52:51 UTC 
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:7f3d900684ad989164114f25eb46a33871c6533d

commit r14-9028-g7f3d900684ad989164114f25eb46a33871c6533d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Feb 7 11:31:10 2024 +0000

    libstdc++: Fix FAIL: 26_numerics/random/pr60037-neg.cc [PR113931]
    
            PR libstdc++/87744
            PR libstdc++/113931
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/26_numerics/random/pr60037-neg.cc: Adjust dg-error
            line number.
Comment 5 Jonathan Wakely 2024-02-16 11:48:00 UTC 
fixed now