Bug 10917 - pch tests don't corrrectly copy symlinks
Summary: pch tests don't corrrectly copy symlinks
Alias: None
Product: gcc
Classification: Unclassified
Component: pch (show other bugs)
Version: 3.4.0
: P2 normal
Target Milestone: 3.4.0
Assignee: Geoff Keating
Depends on:
Reported: 2003-05-21 20:36 UTC by H.J. Lu
Modified: 2003-06-07 15:05 UTC (History)
2 users (show)

See Also:
Known to work:
Known to fail:
Last reconfirmed:

A patch to correctly copy symlinks (1.24 KB, patch)
2003-05-21 20:37 UTC, H.J. Lu
Details | Diff
An updated patch (1.12 KB, patch)
2003-06-06 03:06 UTC, H.J. Lu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description H.J. Lu 2003-05-21 20:36:35 UTC
g++.dg/pch/pch.exp and gcc.dg/pch/pch.exp use "file copy"
to copy files. But it doesn't work well with relative symlinks
since "file copy" will just copy symlinks, which is usually
incorrect for relative symlinks.
Comment 1 H.J. Lu 2003-05-21 20:37:22 UTC
Created attachment 4046 [details]
A patch to correctly copy symlinks
Comment 2 Andrew Pinski 2003-05-27 17:55:42 UTC
Could you send your patch to gcc-patches@gcc.gnu.org as reviewers do not always 
read bugs for patches?
Comment 3 H.J. Lu 2003-05-27 18:21:05 UTC


I suggest assign this bug to mrs@apple.com or geoffk@apple.com.
Comment 4 Andrew Pinski 2003-05-27 18:27:44 UTC
I assigned it to geoffk@gcc.gnu.org aka geoffk@apple.com.
Comment 5 H.J. Lu 2003-06-06 03:06:20 UTC
Created attachment 4176 [details]
An updated patch

This one works with Mark's changes.
Comment 6 Andrew Pinski 2003-06-07 15:05:35 UTC
Patch checked in: <http://gcc.gnu.org/ml/gcc-cvs/2003-06/msg00302.html>