Bug 101234 - Two tests require en_US.ISO-8859-15 but glibc no longer installs that by default.
Summary: Two tests require en_US.ISO-8859-15 but glibc no longer installs that by defa...
Status: UNCONFIRMED
Alias: None
Product: gcc
Classification: Unclassified
Component: libstdc++ (show other bugs)
Version: 11.1.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-28 01:50 UTC by Ken Moffat
Modified: 2021-06-28 09:18 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Moffat 2021-06-28 01:50:37 UTC
In 22_locale/codecvt/out/wchar_t/3.cc and 22_locale/codecvt/in/wchar_t/3.cc the tests are only run if dejagnu finds the en_US.ISO-8859-15 locale. I assume that glibc used to install that when installing all locales (e.g. [https://centos.pkgs.org/8-stream/centos-baseos-x86_64/glibc-langpack-en-2.28-155.el8.x86_64.rpm.html] implies that), but recent glibc does not automatically install it.

My earliest available old system is using glibc-2.30 and there that locale was not installed when I installed all locales.

Manually installing it on a current system with glibc-2.33, the number of expected passes increased by 4 so the tests do still work, it is just that most builders will not run them.

If I'm reading the tests correctly, they convert the whole character-set. Perhaps they could be converted to use one of the @euro locales which are still installed automatically by glibc ?  I see that at least de_DE@euro and es_ES@euro are in that category and alreadty used by other tests.
Comment 1 Andrew Pinski 2021-06-28 02:15:13 UTC
Looks like the testsuite is incorrect, it should have been 'en_US.ISO8859-15'
Comment 2 Harald van Dijk 2021-06-28 08:02:48 UTC
(In reply to Ken Moffat from comment #0)
> In 22_locale/codecvt/out/wchar_t/3.cc and 22_locale/codecvt/in/wchar_t/3.cc
> the tests are only run if dejagnu finds the en_US.ISO-8859-15 locale. I
> assume that glibc used to install that when installing all locales (e.g.
> [https://centos.pkgs.org/8-stream/centos-baseos-x86_64/glibc-langpack-en-2.
> 28-155.el8.x86_64.rpm.html] implies that), but recent glibc does not
> automatically install it.

This locale was and is a Red Hat change, not something that used to be part of official glibc: <https://src.fedoraproject.org/rpms/glibc/blob/rawhide/f/glibc-fedora-localedata-rh61908.patch>. This patch is still used by Red Hat now.

(Not that that means the test should continue using this locale.)
Comment 3 Jonathan Wakely 2021-06-28 09:18:47 UTC
(In reply to Andrew Pinski from comment #1)
> Looks like the testsuite is incorrect, it should have been 'en_US.ISO8859-15'

I think that's exactly equivalent, the extra dash is optional.