Summary: | [11 Regression] ICE in duplicate, at ipa-prop.c:4251 since r11-3478-gada353b87909fd6c | ||
---|---|---|---|
Product: | gcc | Reporter: | Arseny Solokha <asolokha> |
Component: | ipa | Assignee: | Jan Hubicka <hubicka> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | hubicka, jamborm, marxin |
Priority: | P1 | Keywords: | ice-on-valid-code |
Version: | 11.0 | ||
Target Milestone: | 11.0 | ||
Host: | Target: | ||
Build: | Known to work: | ||
Known to fail: | 11.0 | Last reconfirmed: | 2020-09-29 00:00:00 |
Description
Arseny Solokha
2020-09-29 01:36:29 UTC
Confirmed, started with r11-3478-gada353b87909fd6c. I am testing this fix. Problem is that when modref is disabled we never relase ipa-prop datastructures. 2020-09-30 Jan Hubicka <hubicka@ucw.cz> * ipa-fnsummary.c: (pass_free_fnsummary:execute): Call ipa_free_all_structures_after_iinln. * ipa-modref.c (pass_ipa_modref::execute): Do not call ipa_free_all_structures_after_iinln. * ipa-prop.c (ipa_free_all_node_params): Do not crash if info is not allocated. (ipa_unregister_cgraph_hooks): Likewise. diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c index 4c1c1f91482..8285cc00d33 100644 --- a/gcc/ipa-fnsummary.c +++ b/gcc/ipa-fnsummary.c @@ -4680,6 +4680,8 @@ public: virtual unsigned int execute (function *) { ipa_free_fn_summary (); + /* Free ipa-prop structures if they are no longer needed. */ + ipa_free_all_structures_after_iinln (); if (!flag_wpa) ipa_free_size_summary (); return 0; diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c index 6225552e41a..2f4da8f2a14 100644 --- a/gcc/ipa-modref.c +++ b/gcc/ipa-modref.c @@ -1681,8 +1681,6 @@ pass_ipa_modref::execute (function *) } ((modref_summaries *)summaries)->ipa = false; ipa_free_postorder_info (); - /* Free ipa-prop structures if they are no longer needed. */ - ipa_free_all_structures_after_iinln (); return 0; } diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c index b28c78eeab4..ea88fd3fd95 100644 --- a/gcc/ipa-prop.c +++ b/gcc/ipa-prop.c @@ -4124,7 +4124,8 @@ ipa_free_all_edge_args (void) void ipa_free_all_node_params (void) { - ggc_delete (ipa_node_params_sum); + if (ipa_node_params_sum) + ggc_delete (ipa_node_params_sum); ipa_node_params_sum = NULL; } @@ -4368,7 +4369,8 @@ ipa_register_cgraph_hooks (void) static void ipa_unregister_cgraph_hooks (void) { - symtab->remove_cgraph_insertion_hook (function_insertion_hook_holder); + if (function_insertion_hook_holder) + symtab->remove_cgraph_insertion_hook (function_insertion_hook_holder); function_insertion_hook_holder = NULL; } |