| Summary: | [8 Regression] GCC 8 chokes on std::max in alignas | ||
|---|---|---|---|
| Product: | gcc | Reporter: | David Seifert <soap> |
| Component: | c++ | Assignee: | Marek Polacek <mpolacek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | daniel.kruegler, mpolacek, polacek, webrown.cpp |
| Priority: | P3 | Keywords: | rejects-valid |
| Version: | 8.4.0 | ||
| Target Milestone: | 8.5 | ||
| Host: | Target: | ||
| Build: | Known to work: | 10.0, 11.0, 5.5.0, 9.2.0 | |
| Known to fail: | 6.5.0, 7.5.0, 8.4.0 | Last reconfirmed: | 2020-05-03 00:00:00 |
. *** This bug has been marked as a duplicate of bug 90736 *** Hmm, although this was fixed for gcc 9.2 by the patch for PR 90736 it seems to be a different root cause. This compiled with GCC 5 but not 6, 7 or 8: template<typename T> constexpr const T& max(const T& a, const T& b) { return a < b ? b : a; } struct One {}; struct Two {}; struct Foo { alignas(max(alignof(One), alignof(Two))) char value; }; This regressed with r230365, "Merge C++ delayed folding branch." Marek, looks like backporting r272219 would fix this. I'm going to backport the fix to 8 if it passes the usual testing. (In reply to Marek Polacek from comment #3) > I'm going to backport the fix to 8 if it passes the usual testing. Hi Marek, could you also test the inlined code. Defining some const and then using it alignas worked previously, the problem comes from doing all of it in alignas(). (In reply to David Seifert from comment #5) > (In reply to Marek Polacek from comment #3) > > I'm going to backport the fix to 8 if it passes the usual testing. > > Hi Marek, > could you also test the inlined code. Defining some const and then using it > alignas worked previously, the problem comes from doing all of it in > alignas(). Both the original testcase in this PR and the test in Comment 2 now compile even with GCC 8. |
The following snippet #include <algorithm> struct One {}; struct Two {}; struct Foo { alignas(std::max(alignof(One), alignof(Two))) char value; }; compiles fine in GCC 9.3, but in GCC 8.4 fails with test.cpp:5:65: error: requested alignment is not an integer constant struct Foo { alignas(std::max(alignof(One), alignof(Two))) char value; }; ^~~~~