Bug 55901

program characterconversions
    integer :: i=123
    character(len=*) :: s
    write(s,*) i
    print *,s
end program

I am getting the below error while executing the above program (gcc version 4.8.0 20130302 (experimental) [trunk revision 196403] (GCC))

Error: Entity with assumed character length  must be a dummy argument or a PARAMETER|
||=== Build finished: 1 errors, 0 warnings (0 minutes, 0 seconds) ===|

(In reply to comment #1)
> program characterconversions
>     integer :: i=123
>     character(len=*) :: s
>     write(s,*) i
>     print *,s
> end program
> 
> I am getting the below error while executing the above program (gcc version
> 4.8.0 20130302 (experimental) [trunk revision 196403] (GCC))
> 
> Error: Entity with assumed character length  must be a dummy argument or a
> PARAMETER|
> ||=== Build finished: 1 errors, 0 warnings (0 minutes, 0 seconds) ===|

Your example has nothing to do with the original PR.

It is also invalid code: you must not use assumed character length (i.e. len=*)
in a main program.

(In reply to comment #2)
> (In reply to comment #1)
> > program characterconversions
> >     integer :: i=123
> >     character(len=*) :: s
> >     write(s,*) i
> >     print *,s
> > end program
> > 
> > I am getting the below error while executing the above program (gcc version
> > 4.8.0 20130302 (experimental) [trunk revision 196403] (GCC))
> > 
> > Error: Entity with assumed character length  must be a dummy argument or a
> > PARAMETER|
> > ||=== Build finished: 1 errors, 0 warnings (0 minutes, 0 seconds) ===|
> 
> Your example has nothing to do with the original PR.
> 
> It is also invalid code: you must not use assumed character length (i.e. len=*)
> in a main program.

Hi Harald,

I am newbie to fortran, Can you please explain me in detail with an example.

Thanks in advance

(In reply to comment #3)
> I am newbie to fortran, Can you please explain me in detail with an example.
> 
> Thanks in advance

Replace

    character(len=*) :: s

in your code by e.g.

    character(len=20) :: s

Then it will compile work.  This is a general Fortran issue
and has nothing to do with gfortran.

Note: the bugzilla should not be used to learn about Fortran.
Use a textbook about Fortran or the newsgroup "comp.lang.fortran"
which you can access via google groups.

Here is another code which triggers this error:

ftp://ftp.numerical.rl.ac.uk/pub/MRandC/oo.f90

(cf. also https://groups.google.com/forum/?fromgroups#!topic/comp.lang.fortran/aRz3HMpblTs)

Any news on this one?

(In reply to Harald Anlauf from comment #6)
> Any news on this one?

Dear Harald,

I'll take a look at it tonight. Andre is working on a patch that will allow the likes of oo.f90 to work correctly with characters. This bug gets in the way and so I will see what can be done :-) It should be trivial.....

Cheers

Paul

Created attachment 34281 [details]
Partial patch for the PR

This patch removes the error and correctly converts the code, except for the lack of a string length for the unlimited polymorphic entities/components in both the testcase here and oo.f90.

Andre is attending to this but I will in the meantime submit this patch.

Cheers

Paul

By the way, the patch of comment 8 bootstraps and regtests OK

Paul

(In reply to paul.richard.thomas@gmail.com from comment #9)
> By the way, the patch of comment 8 bootstraps and regtests OK
> 
> Paul

Hi Paul,

any news on that patch?

Harald

Hi Harald,

Happy New Year! I have been away in Claifornia these last few weeks and
just got back last night.

I am working with Andre on pr60255 tonight. Once this is done, we should be
in a position to fix pr55901 and have it do something useful!

Cheers

Paul

On 6 January 2015 at 20:50, anlauf at gmx dot de <gcc-bugzilla@gcc.gnu.org>
wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55901
>
> --- Comment #10 from Harald Anlauf <anlauf at gmx dot de> ---
> (In reply to paul.richard.thomas@gmail.com from comment #9)
> > By the way, the patch of comment 8 bootstraps and regtests OK
> >
> > Paul
>
> Hi Paul,
>
> any news on that patch?
>
> Harald
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>

Hi Paul, hi Tobias,

I am guilty in asking both of you to look at the issue. I would be very happy,
if one of you two can really have a look into the issue and notify the other
one, that he found a reason for the issue and may be already has a solution. I
just want to get the issue resolved but not produce duplicate work.

Regards,
	Andre


On Wed, 07 Jan 2015 13:16:25 +0000
"paul.richard.thomas at gmail dot com" <gcc-bugzilla@gcc.gnu.org> wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55901
> 
> --- Comment #11 from paul.richard.thomas at gmail dot com
> <paul.richard.thomas at gmail dot com> --- Hi Harald,
> 
> Happy New Year! I have been away in Claifornia these last few weeks and
> just got back last night.
> 
> I am working with Andre on pr60255 tonight. Once this is done, we should be
> in a position to fix pr55901 and have it do something useful!
> 
> Cheers
> 
> Paul
> 
> On 6 January 2015 at 20:50, anlauf at gmx dot de <gcc-bugzilla@gcc.gnu.org>
> wrote:
> 
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55901
> >
> > --- Comment #10 from Harald Anlauf <anlauf at gmx dot de> ---
> > (In reply to paul.richard.thomas@gmail.com from comment #9)
> > > By the way, the patch of comment 8 bootstraps and regtests OK
> > >
> > > Paul
> >
> > Hi Paul,
> >
> > any news on that patch?
> >
> > Harald
> >
> > --
> > You are receiving this mail because:
> > You are on the CC list for the bug.
> >
>

Author: pault
Date: Sun Jan 18 12:21:38 2015
New Revision: 219814

URL: https://gcc.gnu.org/viewcvs?rev=219814&root=gcc&view=rev
Log:
2015-01-18  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/55901
	* primary.c (gfc_match_varspec): Exclude dangling associate-
	names with dimension 0 from being counted as arrays.
	* resolve.c (resolve_assoc_var): Sub-strings are permissible
	for associate-names, so exclude characters from the test for
	misuse as arrays.
	* trans-decl.c (gfc_get_symbol_decl): Associate-names can use
	the hidden string length variable of their associated target.
	Signal this by setting 'length' to a constant, if the decl for
	the string length is a variable.

2015-01-18  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/55901
	* gfortran.dg/associate_1.f03: Allow test for character with
	automatic length.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/primary.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/associate_1.f03

Fix available with:

https://gcc.gnu.org/ml/fortran/2015-03/msg00074.html
https://gcc.gnu.org/ml/fortran/2015-03/msg00075.html
https://gcc.gnu.org/ml/fortran/2015-03/msg00085.html

and

https://gcc.gnu.org/ml/fortran/2015-03/msg00086.html

Author: vehre
Date: Tue Mar 24 11:47:45 2015
New Revision: 221627

URL: https://gcc.gnu.org/viewcvs?rev=221627&root=gcc&view=rev
Log:
2015-03-24  Andre Vehreschild  <vehre@gmx.de>

	PR fortran/55901
	* trans-expr.c (gfc_conv_structure): Fixed indendation.
	Using integer_zero_node now instead of explicitly
	constructing a integer constant zero node.
	(gfc_conv_derived_to_class): Add handling of _len component,
	i.e., when the rhs has a string_length then assign that to
	class' _len, else assign 0.
	(gfc_conv_intrinsic_to_class): Likewise.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-expr.c

Fixed with commit r221627.

*** Bug 60561 has been marked as a duplicate of this bug. ***