Bug 55353

Summary:	[asan] the flag for asan should match the one used in clang
Product:	gcc	Reporter:	Konstantin Serebryany <konstantin.s.serebryany>
Component:	sanitizer	Assignee:	Not yet assigned to anyone <unassigned>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dodji, dseketel, dvyukov, hjl.tools, jakub, jakub, kcc
Priority:	P3
Version:	unknown
Target Milestone:	---
Host:		Target:
Build:		Known to work:
Known to fail:		Last reconfirmed:

Description Konstantin Serebryany 2012-11-16 16:57:01 UTC

Currently, gcc trunk uses -faddress-sanitizer
Clang has recently changed the flag to -fsanitize=address
(there was a data race between clang change and gcc review-commit cycle :)

We need to match the flags. 

Same applies to tsan (seems like it is not committed to gcc yet)

Comment 1 Konstantin Serebryany 2012-11-19 05:20:24 UTC

Wei, this needs to happen ASAP, otherwise there will be too many places with the old flag.

Comment 2 wmi 2012-11-19 05:54:44 UTC

Hi Kostya,

Ok, I will extract the change from the tsan patch and send out a
separate patch about it.

Regards,
Wei.

On Sun, Nov 18, 2012 at 9:20 PM, konstantin.s.serebryany at gmail dot
com <gcc-bugzilla@gcc.gnu.org> wrote:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55353
>
> Konstantin Serebryany <konstantin.s.serebryany at gmail dot com> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |hjl.tools at gmail dot com,
>                    |                            |wmi at gcc dot gnu.org
>
> --- Comment #1 from Konstantin Serebryany <konstantin.s.serebryany at gmail dot com> 2012-11-19 05:20:24 UTC ---
> Wei, this needs to happen ASAP, otherwise there will be too many places with
> the old flag.
>
> --
> Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.

Comment 3 Jakub Jelinek 2012-11-19 07:45:31 UTC

Yes, please.  But make sure to update all the spots where -faddress-sanitizer is used in the tree (e.g. gcc/testsuite/lib/asan-dg.exp, gcc/doc/*, etc.).

Comment 4 Yury Gribov 2013-11-13 09:24:23 UTC

Could someone close this? Was fixed in r193702

Comment 5 Kostya Serebryany 2013-11-13 09:28:53 UTC

fixed indeed.