Summary: | [4.7 regression] internal compiler error: in distribute_notes, at combine.c:13285 for libgomp/alloc.c on m68k-linux | ||
---|---|---|---|
Product: | gcc | Reporter: | Mikael Pettersson <mikpelinux> |
Component: | bootstrap | Assignee: | Not yet assigned to anyone <unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jakub, zsojka |
Priority: | P3 | ||
Version: | 4.7.0 | ||
Target Milestone: | 4.7.0 | ||
Host: | Target: | m68k-linux | |
Build: | Known to work: | ||
Known to fail: | Last reconfirmed: | ||
Attachments: |
preprocessed source for libgomp/alloc.c
reduced test case gcc47-pr51796.patch |
Description
Mikael Pettersson
2012-01-09 08:18:47 UTC
It's caused by r182924: Author: jakub Date: Thu Jan 5 20:47:16 2012 New Revision: 182924 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182924 Log: PR debug/51762 * calls.c (emit_call_1): For noreturn calls force a REG_ARGS_SIZE note when !ACCUMULATE_OUTGOING_ARGS. m68k is !ACCUMULATE_OUTGOING_ARGS, so it triggers this change. Created attachment 26279 [details]
reduced test case
I guess the assert should be adjusted, from gcc_assert (old_size != args_size); to gcc_assert (old_size != args_size || find_reg_note (i3, REG_NORETURN, NULL)); because we add the REG_ARGS_SIZE notes now even to noreturn calls where there is no difference from previous args size. Can't test it right now though. The "|| find_reg_note (i3, REG_NORETURN, NULL)" bit also failed because i3 has no notes at all. INSN_CODE (i3) == 437, which seems to correspond to "*call" from m68k.md. Created attachment 26288 [details] gcc47-pr51796.patch Ah, REG_UNUSED might be still in next_note chain, not processed yet by distribute_notes. Completely (not even compile time) tested patch. Still fails in gcc_assert (n). I hit this (probably) ICE with more obscure flags, with a x86_64-unknown-linux-gnu target: $ gcc -Os -fno-omit-frame-pointer -fno-tree-dominator-opts -fno-tree-fre -fno-tree-pre testsuite/gcc.c-torture/compile/pr39941.c testsuite/gcc.c-torture/compile/pr39941.c: In function 'bsd_boot': testsuite/gcc.c-torture/compile/pr39941.c:11:1: internal compiler error: in distribute_notes, at combine.c:13285 Please submit a full bug report, with preprocessed source if appropriate. See <http://gcc.gnu.org/bugs.html> for instructions. Ah, obviously s/REG_UNUSED/REG_NORETURN/g in the patch, sorry for that. (In reply to comment #8) > Ah, obviously s/REG_UNUSED/REG_NORETURN/g in the patch, sorry for that. With the above modification I can now build a cross successfully. I'll resume my native bootstrap now with it applied and see how it goes. Author: jakub Date: Wed Jan 11 22:59:12 2012 New Revision: 183111 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183111 Log: PR bootstrap/51796 * combine.c (distribute_notes): If i3 is a noreturn call, allow old_size to be equal to args_size and make sure the noreturn call gets REG_ARGS_SIZE note. * expr.c (fixup_args_size_notes): Put REG_ARGS_SIZE notes on noreturn calls even when the delta is 0. * gcc.dg/pr51796.c: New test. Added: trunk/gcc/testsuite/gcc.dg/pr51796.c Modified: trunk/gcc/ChangeLog trunk/gcc/combine.c trunk/gcc/expr.c trunk/gcc/testsuite/ChangeLog Should be fixed now. |