| Summary: | fixincludes hacks around a C++ deficiency | ||
|---|---|---|---|
| Product: | gcc | Reporter: | Bruce Korb <bkorb> |
| Component: | preprocessor | Assignee: | Not yet assigned to anyone <unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | egallager, sjames |
| Priority: | P3 | ||
| Version: | 4.7.0 | ||
| Target Milestone: | --- | ||
| Host: | Target: | ||
| Build: | Known to work: | ||
| Known to fail: | Last reconfirmed: | ||
| Bug Depends on: | 53528 | ||
| Bug Blocks: | |||
Author: andreast Date: Wed Jan 11 16:23:48 2012 New Revision: 183096 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183096 Log: 2012-01-11 Bruce Korb <bkorb@gnu.org> Steven G. Kargl <kargl@gcc.gnu.org> Andreas Tobler <andreast@fgznet.ch> PR bootstrap/57105 PR preprocessor/51776 * inclhack.def (cdef_cplusplus): Add a replacement for [[noreturn]]. * fixincl.x: Regenerate. * tests/base/sys/cdefs.h: Update. * genfixes: Remove the 'Ver.' from the version check. Modified: trunk/fixincludes/ChangeLog trunk/fixincludes/fixincl.x trunk/fixincludes/genfixes trunk/fixincludes/inclhack.def trunk/fixincludes/tests/base/sys/cdefs.h adding the "Support C++11 generalized attributes" PR as a dependency so Bruce gets prodded when it changes state (In reply to comment #2) > adding ... PR as a dependency so Bruce gets prodded when it changes state Bruce has now been prodded. :) I will fix this in 3 weeks or so. The depends bug 53528 "Support C++11 generalized attributes" has been closed, and applied to trunk (4.8). This hack is no longer in inclhack.def. (In reply to Bruce Korb from comment #0) > CF: bug #51705 comment #25 (In reply to Andreas Tobler from comment #1) > PR bootstrap/57105 OK so there are two similar-looking bug numbers here; I'm assuming the first one is the correct one, and the second was a typo? |
a new fixinclude hack is about to be added to paper over the fact that g++ -std=c++11 claims full compliance, but is slightly deficient. Once that is fixed, this new hack should be removed. It will be approximately thus: +/* + * g++ -std=c++11 defines __cplusplus to 201103L, but does not + * properly support [[noreturn]]. + */ +fix = { + hackname = cdef_cplusplus; + files = sys/cdefs.h; + select = '\[\[noreturn\]\]'; + c_fix = format; + c_fix_arg = "__attribute__((__noreturn__))"; + test_text = "#define _Noreturn [[noreturn]]"; +}; CF: bug #51705 comment #25