Bug 32727

Created attachment 13883 [details]
testcase

FYI, all three modules are needed to trigger the bug. 

Working: 2007-07-09-r126478
Failing: 2007-07-10-r126510

I believe it is due to the patch
 r126509 | pault | 2007-07-10 07:11:00 +0200 (Di, 10 Jul 2007) | 28 lines
        PR 32634 [...]
        * module.c (write_generic): Write the local name of the
        interface.
but I might be wrong and it is one of:
 r126486 | dfranke | 2007-07-09 16:56:49 +0200 (Mon, 09 Jul 2007) | 14 lines
 r126493 | kargl | 2007-07-09 21:41:37 +0200 (Mon, 09 Jul 2007) | 6 lines
 r126496 | fxcoudert | 2007-07-10 00:00:52 +0200 (Tue, 10 Jul 2007) | 6 lines

The error message is:

  USE util,                            ONLY: sort
                                           1
Error: Symbol 'sort' referenced at (1) not found in module 'util'


Reduced test case:

MODULE kinds
  INTEGER, PARAMETER :: dp = SELECTED_REAL_KIND ( 14, 200 )
END MODULE kinds

MODULE util
  USE kinds,                           ONLY: dp
  INTERFACE sort
     MODULE PROCEDURE sort2
  END INTERFACE
CONTAINS
  SUBROUTINE sort2 ( )
  END SUBROUTINE sort2
END MODULE util

MODULE graphcon
  USE util,                            ONLY: sort
END MODULE graphcon

No error up to and including r126496. That leaves only Paul's patch ...

(In reply to comment #4)
> No error up to and including r126496. That leaves only Paul's patch ...
> 
Daniel,

Could you please revert r126496 and re-open the PR? - I can do nothing about it for 10 days or more.

Cheers

Paul

(In reply to comment #5)

Daniel,

Hmmm!  Cancel that - I'll have a slot this evening where I can either fix it or revert it myself.  Just leave it to me but, I'll let you know if I am unable to do the business.

Paul - who is run off his feet but wants to fix those bugs...

Subject: Bug 32727

Author: dfranke
Date: Thu Jul 12 06:31:12 2007
New Revision: 126572

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126572
Log:
2007-07-12  Daniel Franke  <franke.daniel@gmail.com>

        PR fortran/32634
        PR fortran/32727
        * module.c: Reverted Paul's patch from 2007-07-10.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c

Sorry, too late :(

(In reply to comment #8)
> Sorry, too late :(

Fine with me :-), I can give gfortran another round of testing today... thanks

BTW, if you revert a patch, you should add the testcase that is the reason it. To avoid regressing again if the patch gets re-applied. Similarly, you should xfail the other testcase that now fails.

> BTW, if you revert a patch, you should add the testcase that is the reason
> it. To avoid regressing again if the patch gets re-applied. Similarly, you
> should xfail the other testcase that now fails.

Joost,

good point. I thought about XFAIL, but then again, probably nobody will notice that there's something wrong since it's expected to fail. Hence I concluded that it would be preferable to have people asking about a testsuite failure twice a day then to hide the problem it in an xfail :)

However, if Paul does find the time today, I'm positive that he will set it right -- otherwise I will implement your suggestion tomorrow.

*** Bug 32741 has been marked as a duplicate of this bug. ***

Subject: Bug 32727

Author: pault
Date: Thu Jul 12 20:04:59 2007
New Revision: 126600

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126600
Log:
2007-07-12  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/32634
	PR fortran/32727
	* module.c (write_generic): Restore patch of 2007-07-10 and use
	symbol name if there are no use names. 

2007-07-12  Paul Thomas  <pault@gcc.gnu.org>

	PR fortran/32727
	* gfortran.dg/interface_17.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/interface_17.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog

Thanks for the very prompt report.

I would use your cp2k testcase but it does not compile on Cygwin - it runs out of memory during compilation. When I have a moment, I'll break itup.

Fixed on trunk

Paul

(In reply to comment #13)
> I would use your cp2k testcase but it does not compile on Cygwin - it runs out
> of memory during compilation. When I have a moment, I'll break itup.

yes, it can be trivially split after every module, and compiled in that order. The other option is to check (a fixed version) out from cvs. See 
http://cp2k.berlios.de/download.html. That might initially be a few minutes more work to setup, but has the advantage that make -j X speeds up testing and that miscompilations can be more easily found.