Bug 18757

Summary: [3.4 Regression] ICE (on invalid) in get_innermost_template_args
Product: gcc Reporter: Jakub Jelinek <jakub>
Component: c++Assignee: Alexandre Oliva <aoliva>
Status: RESOLVED FIXED    
Severity: normal CC: gcc-bugs, reichelt
Priority: P2 Keywords: accepts-invalid, ice-on-invalid-code, monitored, patch
Version: 4.0.0   
Target Milestone: 3.4.4   
Host: Target:
Build: Known to work: 4.0.0
Known to fail: Last reconfirmed: 2004-12-01 15:20:50

Description Jakub Jelinek 2004-12-01 15:16:38 UTC 
When compiling:
struct S
{
  typedef void *P;
};

namespace M
{
  typedef void *P;
};

namespace N
{
class S;
struct N
{
  template <typename T> void foo (typename T::P);
};

struct R
{
  N& n;
  template <class U, class T> inline void bar (U p);
  void baz (M::P);
};

template <class U, class T>
inline void
R::bar (U p)
{
  n.foo <typename T> (p);
  delete this;
}

void R::baz (M::P p)
{
  bar <M::P, S>(p);
}

}

I get:
141300.ii: In member function `void N::R::bar(U) [with U = void*, T = N::S]':
141300.ii:36:   instantiated from here
141300.ii:30: internal compiler error: tree check: expected tree_vec, have
error_mark in get_innermost_template_args, at cp/pt.c:575
with checking enabled and usually segfault with checking disabled, in both
GCC 3.4.x and 4.0.0.
explicit_targs passed down from build_new_method_call is error_mark.
Comment 1 Drea Pinski 2004-12-01 15:20:50 UTC 
: Search converges between 2003-08-10-trunk (#319) and 2003-08-11-trunk (#320).

Confirmed.
Comment 2 Volker Reichelt 2004-12-01 16:24:10 UTC 
Here's a reduced example:

====================================================================
struct A
{
    template<typename>   void foo(int);
    template<typename T> void bar(T t) { this->foo<typename T>(t); }
};

void baz()
{
    A().bar(0);
}
====================================================================

If I remove "this->" the code compiles.
Hence, we have an accepts-invalid, too.
Comment 3 Kriang Lerdsuwanakij 2004-12-08 10:59:07 UTC 
There is a patch here:
  http://gcc.gnu.org/ml/gcc-patches/2004-12/msg00538.html
Comment 4 GCC Commits 2004-12-09 12:33:28 UTC 
Subject: Bug 18757

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aoliva@gcc.gnu.org	2004-12-09 12:33:09

Modified files:
	gcc/cp         : ChangeLog parser.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/g++.dg/parse: typename5.C 
Added files:
	gcc/testsuite/g++.dg/parse: typename7.C 

Log message:
	gcc/cp/ChangeLog:
	PR c++/18757
	* parser.c (cp_parser_template_id): Don't create a CPP_TEMPLATE_ID
	if parsing failed.
	gcc/testsuite/ChangeLog:
	* g++.dg/parse/typename5.C: Adjust for new error.
	* g++.dg/parse/typename7.C: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4524&r2=1.4525
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.290&r2=1.291
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4729&r2=1.4730
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename7.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename5.C.diff?cvsroot=gcc&r1=1.2&r2=1.3
Comment 5 Drea Pinski 2004-12-09 12:38:28 UTC 
Fixed at least on the mainline.
Comment 6 GCC Commits 2004-12-23 16:26:09 UTC 
Subject: Bug 18757

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	aoliva@gcc.gnu.org	2004-12-23 16:25:51

Modified files:
	gcc/cp         : ChangeLog parser.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/g++.dg/parse: typename5.C 
Added files:
	gcc/testsuite/g++.dg/parse: typename7.C 

Log message:
	gcc/cp/ChangeLog:
	PR c++/18757
	* parser.c (cp_parser_template_id): Don't create a CPP_TEMPLATE_ID
	if parsing failed.
	gcc/testsuite/ChangeLog:
	* g++.dg/parse/typename5.C: Adjust for new error.
	* g++.dg/parse/typename7.C: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.186&r2=1.3892.2.187
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.157.2.47&r2=1.157.2.48
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.334&r2=1.3389.2.335
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename7.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename5.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.2&r2=1.2.4.1
Comment 7 Drea Pinski 2004-12-23 16:39:09 UTC 
Fixed.
Comment 8 GCC Commits 2005-02-01 05:56:37 UTC 
Subject: Bug 18757

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	aoliva@gcc.gnu.org	2005-02-01 05:56:08

Modified files:
	gcc/testsuite  : ChangeLog 
	gcc/cp         : ChangeLog parser.c pt.c 
	gcc/testsuite/g++.dg/parse: typename7.C 

Log message:
	gcc/cp/ChangeLog:
	PR c++/18757
	PR c++/19366
	PR c++/19499
	* parser.c (cp_parser_template_id): Revert 2004-12-09's patch.
	Issue an error when creating the template id.
	* pt.c (fn_type_unification): Return early if the explicit
	template arg list is an error_mark_node.
	gcc/testsuite/ChangeLog:
	* g++.dg/parse/typename7.C: Adjust error messages.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.4967&r2=1.4968
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.4607&r2=1.4608
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.306&r2=1.307
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&r1=1.970&r2=1.971
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename7.C.diff?cvsroot=gcc&r1=1.1&r2=1.2
Comment 9 GCC Commits 2005-02-01 07:04:25 UTC 
Subject: Bug 18757

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	aoliva@gcc.gnu.org	2005-02-01 07:04:01

Modified files:
	gcc/testsuite  : ChangeLog 
	gcc/cp         : ChangeLog parser.c pt.c 
	gcc/testsuite/g++.dg/parse: typename7.C 

Log message:
	gcc/cp/ChangeLog:
	PR c++/18757
	PR c++/19366
	PR c++/19499
	* parser.c (cp_parser_template_id): Revert 2004-12-09's patch.
	Issue an error when creating the template id.
	* pt.c (fn_type_unification): Return early if the explicit
	template arg list is an error_mark_node.
	gcc/testsuite/ChangeLog:
	* g++.dg/parse/typename7.C: Adjust error messages.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3389.2.354&r2=1.3389.2.355
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.3892.2.193&r2=1.3892.2.194
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.157.2.50&r2=1.157.2.51
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.816.2.49&r2=1.816.2.50
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/typename7.C.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.1.10.1&r2=1.1.10.2