Summary: | [15 Regression] File label-text.h not part of installation since r15-874-g9bda2c4c81b668 | ||
---|---|---|---|
Product: | gcc | Reporter: | David Binderman <dcb314> |
Component: | plugins | Assignee: | Andrew Pinski <pinskia> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dmalcolm, sjames |
Priority: | P3 | ||
Version: | 15.0 | ||
Target Milestone: | 15.0 | ||
Host: | Target: | ||
Build: | Known to work: | ||
Known to fail: | Last reconfirmed: | 2024-05-30 00:00:00 |
Description
David Binderman
2024-05-30 07:12:55 UTC
I think this fixes the issue (which was introduced by r15-874-g9bda2c4c81b668 ): ``` [apinski@xeond2 gcc]$ git diff Makefile.in diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 66d42cc41f8..67c00a9c23f 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -1038,6 +1038,7 @@ SYSTEM_H = system.h hwint.h $(srcdir)/../include/libiberty.h \ PREDICT_H = predict.h predict.def CPPLIB_H = $(srcdir)/../libcpp/include/line-map.h \ $(srcdir)/../libcpp/include/rich-location.h \ + $(srcdir)/../libcpp/include/label-text.h \ $(srcdir)/../libcpp/include/cpplib.h CODYLIB_H = $(srcdir)/../libcody/cody.hh INPUT_H = $(srcdir)/../libcpp/include/line-map.h input.h ``` Let me double check that and commit as obvious if it works. The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>: https://gcc.gnu.org/g:6e6471806d886bc052d3922d636d49aaf75d5d16 commit r15-1076-g6e6471806d886bc052d3922d636d49aaf75d5d16 Author: Andrew Pinski <quic_apinski@quicinc.com> Date: Thu May 30 07:59:00 2024 -0700 Plugins: Add label-text.h to CPPLIB_H so it will be installed [PR115288] After r15-874-g9bda2c4c81b668, out of tree plugins won't compile as the new libcpp header file label-text.h is not installed. This adds the new header file to CPPLIB_H which is used for the plugin headers to install. Committed as obvious after a build and install and make sure the new header file is installed. gcc/ChangeLog: PR plugins/115288 * Makefile.in (CPPLIB_H): Add label-text.h. Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> I should've said, the obvious patch did indeed work for me. Fixed. Sorry about the breakage; thanks for fixing this |