Bug 92726 - OpenACC: 'NULL'-in -> no-op, and/or 'NULL'-out
Summary: OpenACC: 'NULL'-in -> no-op, and/or 'NULL'-out
Status: WAITING
Alias: None
Product: gcc
Classification: Unclassified
Component: libgomp (show other bugs)
Version: unknown
: P3 normal
Target Milestone: ---
Assignee: Thomas Schwinge
URL:
Keywords: openacc
Depends on:
Blocks:
 
Reported: 2019-11-29 13:26 UTC by Thomas Schwinge
Modified: 2020-01-30 14:40 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2020-01-30 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schwinge 2019-11-29 13:26:45 UTC 
OpenACC is being clarified that when you pass 'NULL' into data clauses, or runtime API functions, that means no-op, and/or a 'NULL' return value.
Comment 1 Thomas Schwinge 2019-12-18 17:01:42 UTC 
Author: tschwinge
Date: Wed Dec 18 17:01:11 2019
New Revision: 279532

URL: https://gcc.gnu.org/viewcvs?rev=279532&root=gcc&view=rev
Log:
[PR92726, PR92970, PR92984] [OpenACC] Clarify 'acc_delete' etc. for 'NULL'-in, non-present data, or size zero

PR92970 "OpenACC 2.5: 'acc_delete' etc. on non-present data is a no-op" is an
actual bug fix, and the other ones are fall-out, currently undefined behavior.

	libgomp/
	PR libgomp/92726
	PR libgomp/92970
	PR libgomp/92984
	* oacc-mem.c (delete_copyout): No-op behavior if 'lookup_host'
	fails.
	(GOACC_enter_exit_data): Simplify accordingly.
	* testsuite/libgomp.oacc-c-c++-common/pr92970-1.c: New file,
	subsuming...
	* testsuite/libgomp.oacc-c-c++-common/lib-17.c: ... this file...
	* testsuite/libgomp.oacc-c-c++-common/lib-18.c: ..., and this
	file.
	* testsuite/libgomp.oacc-c-c++-common/pr92984-1.c: New file,
	subsuming...
	* testsuite/libgomp.oacc-c-c++-common/lib-21.c: ... this file...
	* testsuite/libgomp.oacc-c-c++-common/lib-29.c: ..., and this
	file.
	* testsuite/libgomp.oacc-c-c++-common/pr92726-1.c: New file,
	subsuming...
	* testsuite/libgomp.oacc-c-c++-common/lib-28.c: ... this file.

Added:
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92726-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92970-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92984-1.c
Removed:
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-17.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-18.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-21.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-28.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-29.c
Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/oacc-mem.c
Comment 2 Martin Liška 2020-01-30 11:03:00 UTC 
Can we close it now?
Comment 3 Thomas Schwinge 2020-01-30 14:40:02 UTC 
(In reply to Martin Liška from comment #2)
> Can we close it now?

This is WAITING for OpenACC specification clarification.