Bug 87924 - OpenACC wait clauses without async-arguments
Summary: OpenACC wait clauses without async-arguments
Status: ASSIGNED
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 9.0
: P3 normal
Target Milestone: ---
Assignee: Chung-Lin Tang
URL:
Keywords: openacc, patch
Depends on:
Blocks:
 
Reported: 2018-11-07 19:07 UTC by Thomas Schwinge
Modified: 2019-02-20 10:10 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2018-12-13 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schwinge 2018-11-07 19:07:22 UTC 
As reported in <https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01973.html>, we're currently not taking any action for OpenACC wait clauses without async-arguments.
Comment 1 Thomas Schwinge 2018-11-30 20:40:04 UTC 
Author: tschwinge
Date: Fri Nov 30 20:39:30 2018
New Revision: 266686

URL: https://gcc.gnu.org/viewcvs?rev=266686&root=gcc&view=rev
Log:
[PR87924] Add (XFAILed) test cases for OpenACC wait clauses without async-arguments

	gcc/testsuite/
	PR c/87924
	* c-c++-common/goacc/asyncwait-5.c: Update.
	* gfortran.dg/goacc/asyncwait-5.f: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c
    trunk/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f
Comment 2 Chung-Lin Tang 2019-02-19 14:10:46 UTC 
Author: cltang
Date: Tue Feb 19 14:10:15 2019
New Revision: 269016

URL: https://gcc.gnu.org/viewcvs?rev=269016&root=gcc&view=rev
Log:
2019-02-19  Chung-Lin Tang <cltang@codesourcery.com>

	PR c/87924
	gcc/c/
	* c-parser.c (c_parser_oacc_clause_wait): Add representation of wait
	clause without argument as 'wait (GOMP_ASYNC_NOVAL)', adjust comments.

	gcc/cp/
	* parser.c (cp_parser_oacc_clause_wait): Add representation of wait
	clause without argument as 'wait (GOMP_ASYNC_NOVAL)', adjust comments.

	gcc/fortran/
	* openmp.c (gfc_match_omp_clauses): Add representation of wait clause
	without argument as 'wait (GOMP_ASYNC_NOVAL)'.

	libgomp/
	* oacc-parallel.c (GOACC_parallel_keyed): Remove condition on call to
	goacc_wait().
	(goacc_wait): Handle ACC_ASYNC_NOVAL case, remove goacc_thread() call
	and related adjustment.

	Reviewed-by: Thomas Schwinge  <thomas@codesourcery.com>


Modified:
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/openmp.c
    trunk/libgomp/ChangeLog
    trunk/libgomp/oacc-parallel.c
Comment 3 Thomas Schwinge 2019-02-19 16:04:49 UTC 
Author: tschwinge
Date: Tue Feb 19 16:04:17 2019
New Revision: 269020

URL: https://gcc.gnu.org/viewcvs?rev=269020&root=gcc&view=rev
Log:
[PR87924] OpenACC wait clauses without async-arguments: remove XFAILs

... which the recent r269016 didn't do.

	gcc/testsuite/
	PR c/87924
	* c-c++-common/goacc/asyncwait-5.c: Remove XFAILs.
	* gfortran.dg/goacc/asyncwait-5.f: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/goacc/asyncwait-5.c
    trunk/gcc/testsuite/gfortran.dg/goacc/asyncwait-5.f
Comment 4 Chung-Lin Tang 2019-02-20 10:10:24 UTC 
Author: cltang
Date: Wed Feb 20 10:09:53 2019
New Revision: 269036

URL: https://gcc.gnu.org/viewcvs?rev=269036&root=gcc&view=rev
Log:
Correction of ChangeLog entry, Thomas provided the code for this change.

2019-02-19  Thomas Schwinge  <thomas@codesourcery.com>

	PR c/87924
	* openmp.c (gfc_match_omp_clauses): Add representation of wait clause
	without argument as 'wait (GOMP_ASYNC_NOVAL)'.


Modified:
    trunk/gcc/fortran/ChangeLog