Code Reviews using Rietveld
For a patch to be managed by Rietveld, it needs to be added to the tracking web site at http://codereview.appspot.com/. Full details on using the tool are available at http://code.google.com/p/rietveld/wiki/CodeReviewHelp.
Setting up Rietveld for the first time
You will need:
A copy of upload-gcc-patch.py into your bin directory.
An account on http://codereview.appspot.com
An application-specific password to allow Rietveld access.
Sending a patch for review
To send a patch for review:
- Go to the top of your gcc tree.
Create the patch mypatch.diff in the usual way.
Run upload-gcc-patch.py with the following arguments:
$ upload-gcc-patch.py --send_mail mypatch.diff
If you want to send the patch to specific reviewers, use the argument -r to specify the e-mail address you want to send the patch to.
Once the files and the patch have been uploaded, upload-gcc-patch.py will create an issue on codereview and launch your editor. In there, you will be able to edit your message, add a ChangeLog entry to the patch, etc. This will be the e-mail message that gets sent to email@example.com and any other reviewers you specified with -r.
At the bottom of the message, there will be a URL. You can go to that URL to manage the issue. You can also go to your dashboard of patches by going to http://codereview.appspot.com/mine. Your patch dashboard is the list of patches you have outstanding to review or to be reviewed by others.
Updating an existing patch
If your patch contains several parts, or you simply want to update the original patch you sent for review, you can use the -i option to upload-gcc-patch.py.
- Determine the issue number for the patch you want to update
Run upload-gcc-patch.py -i #######, replacing ####### with the issue number.
This will add another patch set to the issue. Reviewers can then view the new patch set against the original patch, or against the base files that you patched.
Using Rietveld is optional.
- Only patch submitters need to create an account to use it.
- Reviewers do not need to access the online tool nor do they need to create an account to interact with it.
- Every interaction with a Rietveld issue, either via the web interface or e-mail is relayed to e-mail. Exactly like Bugzilla.