Code Reviews using Rietveld

Rietveld is a code review tool that offers a web and an e-mail interface for managing patches (see for the original discussion).

For a patch to be managed by Rietveld, it needs to be added to the tracking web site at Full details on using the tool are available at

Setting up Rietveld for the first time

You will need:

  1. A copy of into your bin directory.

  2. An account on

  3. An application-specific password to allow Rietveld access.

Sending a patch for review

To send a patch for review:

  1. Go to the top of your gcc tree.
  2. Create the patch mypatch.diff in the usual way.

  3. Run with the following arguments:

     $ --send_mail mypatch.diff
  4. If you want to send the patch to specific reviewers, use the argument -r to specify the e-mail address you want to send the patch to.

Once the files and the patch have been uploaded, will create an issue on codereview and launch your editor. In there, you will be able to edit your message, add a ChangeLog entry to the patch, etc. This will be the e-mail message that gets sent to and any other reviewers you specified with -r.

At the bottom of the message, there will be a URL. You can go to that URL to manage the issue. You can also go to your dashboard of patches by going to Your patch dashboard is the list of patches you have outstanding to review or to be reviewed by others.

Updating an existing patch

If your patch contains several parts, or you simply want to update the original patch you sent for review, you can use the -i option to

  1. Determine the issue number for the patch you want to update
  2. Run -i #######, replacing ####### with the issue number.

This will add another patch set to the issue. Reviewers can then view the new patch set against the original patch, or against the base files that you patched.

Important notes

None: rietveld (last edited 2011-04-07 19:50:52 by LawrenceCrowl)