Differences between revisions 1 and 11 (spanning 10 versions)
Revision 1 as of 2014-10-06 23:08:41
Size: 1007
Comment: easy hacks for new contributors
Revision 11 as of 2014-10-15 10:11:27
Size: 2655
Comment: add trivial patch
Deletions are marked like this. Additions are marked like this.
Line 7: Line 7:
 * BUG:PR17843 (easy)
 * BUG:PR53061 (easy)
Line 16: Line 14:
 * BUG:PR49859  * BUG:PR44209 (trivial)
 * BUG:PR49859 (easy)
Line 19: Line 18:
 * BUG:PR60832 (easy)
 * BUG:PR62181 Expected new warning: "adding 'char' to a string does not append to the string" [-Wstring-plus-int] (easy)
Line 22: Line 24:

=== A patch exists but needs to be tested ===

 * Trivial patch:

   {{{#!highlight diff numbers=disable
Index: c-decl.c
===================================================================
--- c-decl.c (revision 216164)
+++ c-decl.c (working copy)
@@ -6754,7 +6754,6 @@
   tree types = 0;
   tree others = 0;
 
- static bool explained_incomplete_types = false;
   bool gave_void_only_once_err = false;
 
   arg_info->had_vla_unspec = current_scope->had_vla_unspec;
@@ -6857,19 +6856,12 @@
      {
        if (b->id)
   /* The %s will be one of 'struct', 'union', or 'enum'. */
- warning (0, "%<%s %E%> declared inside parameter list",
+ warning (0, "%<%s %E%> declared inside parameter list will not be visible outside of this function",
     keyword, b->id);
        else
   /* The %s will be one of 'struct', 'union', or 'enum'. */
- warning (0, "anonymous %s declared inside parameter list",
+ warning (0, "anonymous %s declared inside parameter list will not be visible outside of this function",
     keyword);
-
- if (!explained_incomplete_types)
- {
- warning (0, "its scope is only this definition or declaration,"
- " which is probably not what you want");
- explained_incomplete_types = true;
- }
      }
 
    tag.id = b->id;
}}}

=== Analyzed what needs to be fixed, but no patch ===

 * BUG:PR23087 Misleading warning, "... differ in signedness"
Line 28: Line 76:

=== A patch exists but needs to be updated ===

 * BUG:PR38612 (easy)

These bugs (also called Problem Reports) are great starting points for new contributors to GCC. If you have doubts or questions, don't be afraid to ask in the bugzilla page of each bug.

C-family (bug affects both C and C++)

A patch exists but needs to be tested

Analyzed what needs to be fixed, but no patch

C only

A patch exists but needs to be tested

  • Trivial patch:
    • Index: c-decl.c
      ===================================================================
      --- c-decl.c    (revision 216164)
      +++ c-decl.c    (working copy)
      @@ -6754,7 +6754,6 @@
         tree types    = 0;
         tree others   = 0;
       
      -  static bool explained_incomplete_types = false;
         bool gave_void_only_once_err = false;
       
         arg_info->had_vla_unspec = current_scope->had_vla_unspec;
      @@ -6857,19 +6856,12 @@
                  {
                    if (b->id)
                      /* The %s will be one of 'struct', 'union', or 'enum'.  */
      -               warning (0, "%<%s %E%> declared inside parameter list",
      +               warning (0, "%<%s %E%> declared inside parameter list will not be visible outside of this function",
                               keyword, b->id);
                    else
                      /* The %s will be one of 'struct', 'union', or 'enum'.  */
      -               warning (0, "anonymous %s declared inside parameter list",
      +               warning (0, "anonymous %s declared inside parameter list will not be visible outside of this function",
                               keyword);
      -
      -             if (!explained_incomplete_types)
      -               {
      -                 warning (0, "its scope is only this definition or declaration,"
      -                          " which is probably not what you want");
      -                 explained_incomplete_types = true;
      -               }
                  }
       
                tag.id = b->id;
      

Analyzed what needs to be fixed, but no patch

  • PR23087 Misleading warning, "... differ in signedness"

C++ only

A patch exists but needs to be tested

A patch exists but needs to be updated

Analyzed what needs to be fixed, but no patch

Fortran

Analyzed what needs to be fixed, but no patch

None: EasyHacks (last edited 2019-04-11 09:41:05 by JonathanWakely)