This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] improve performance of std::allocator::deallocate
- From: Pádraig Brady <pbrady at fb dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 20 May 2019 09:17:38 +0000
- Subject: Re: [PATCH] improve performance of std::allocator::deallocate
- References: <1c2176f7-fea0-95db-5826-db71df13a680@fb.com> <20190226135014.GB8507@redhat.com> <0137cc95-fbd1-bb3b-b2a0-7d2eccf2fccf@fb.com> <b6c007ad-0b06-a1f1-82dc-294a80f10204@fb.com> <20190306085051.GE21503@redhat.com> <3fa207cf-7fb0-311a-eba1-c55dbd5539d4@fb.com> <20190306094400.GG21503@redhat.com> <e27fae27-44e6-7133-4081-1965e37686bb@fb.com> <20190307114331.GL21503@redhat.com> <97abb7b5-467d-d13b-6fe5-2efd29da6e4c@fb.com>
On 04/02/2019 07:33 PM, Padraig Brady wrote:
> On 03/07/2019 03:43 AM, Jonathan Wakely wrote:
>> OK, that makes me feel better about it. It's presumably much easier to
>> upgrade to 5.2 from 5.0 or 5.1 than it would be from 4.x.
>>
>>>> How complicated is the fix to prevent the crashes? Would it be
>>>> feasible for distros to backport that fix? I see that RHEL8 has
>>>> jemalloc 5.0.1 for example, but if the fix could be backported to that
>>>> release then it's less of a problem.
>>> The patch set is simple enough:
>>> https://github.com/jemalloc/jemalloc/pull/1341/commits
>> Thanks. That does seem reasonable for distros and other packagers to
>> backport, if they want to support 5.0 or 5.1 for their users.
>>
>> I'm leaning towards accepting the patch for gcc-9 (and if not, we
>> should do it early in the gcc-10 cycle).
>>
> FYI jemalloc 5.2 is released with the fix for zero sized deallocations:
> https://github.com/jemalloc/jemalloc/releases/tag/5.2.0
>
Friendly ping.
I can create a bug to track if you prefer.
cheers,
Pádraig