This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Make vector<bool> iterator operators hidden friends
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 10 May 2019 14:40:00 +0100
- Subject: Re: Make vector<bool> iterator operators hidden friends
- References: <e1366368-b131-569f-b39b-675733b1aea8@gmail.com>
On Thu, 9 May 2019 at 06:49, François Dumont wrote:
>
> Hi
>
> Patch similar to the one I just apply for deque iterator including
> NRVO copy ellision fix.
>
> * include/bits/stl_bvector.h
> (operator==(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Make hidden friend.
> (operator<(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (operator!=(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (operator>(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (operator<=(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (operator>=(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (operator-(const _Bit_iterator_base&, const _Bit_iterator_base&)):
> Likewise.
> (_Bit_iterator::operator+(difference_type)): Likewise and allow NRVO
> copy elision.
> (_Bit_iterator::operator-(difference_type)): Likewise.
> (operator+(ptrdiff_t, const _Bit_iterator&)): Make hidden friend.
> (_Bit_const_iterator::operator+(difference_type)): Likewise and allow
> NRVO copy elision.
> (_Bit_const_iterator::operator-(difference_type)): Likewise.
> (operator+(ptrdiff_t, const _Bit_const_iterator&)): Make hidden friend.
These const_iterator overloads seem to be missing the NRVO fix.