Re: [PATCH] Fix directory_iterator handling of DT_UNKNOWN

[Jonathan Wakely <jwakely at redhat dot com>]

On 08/04/19 09:18 +0200, Christophe Lyon wrote:
> On Fri, 5 Apr 2019 at 18:57, Jonathan Wakely <jwakely@redhat.com> wrote:
> > We need to handle DT_UNKNOWN earlier, not only during directory
> > recursion, so that the cached file_type value in the directory_entry
> > won't be used.
> >
> >         * src/c++17/fs_dir.cc (_Dir::advance(bool, error_code&)): Handle
> >         d_type == DT_UNKNOWN immediately.
> >         (_Dir::should_recurse(bool, error_code&)): Remove file_type::unknown
> >         handling here.
> >         * testsuite/27_io/filesystem/iterators/caching.cc: New test.
> >
> > Tested powerpc64le-linux, committed to trunk.
>
> Hi,
>
> The new caching.cc test was lacking
> +// { dg-require-filesystem-ts "" }
> which I committed as obvious as r270199.

Thanks. I've added a Git pre-commit hook to stop me doing that again.