This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant
- From: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Apr 2019 13:05:29 +0300
- Subject: Re: [PATCH] PR libstdc++/85184 remove debug assertions from std::variant
- References: <20190403094824.GA824@redhat.com> <CAFk2RUaMZvSyCHMntzravGNEhHDbC06o=579s21iiTXJZV0AjQ@mail.gmail.com>
On Wed, 3 Apr 2019 at 13:04, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
>
> On Wed, 3 Apr 2019 at 12:48, Jonathan Wakely <jwakely@redhat.com> wrote:
> >
> > The __glibcxx_assert macro should be used to check preconditions that
> > users must meet, not to check postconditions that the implementation
> > must meet. We have tests to verify std::variant meets its
> > postconditions, users shouldn't pay for those checks at runtime.
> >
> > PR libstdc++/85184
> > * include/std/variant (_Copy_assign_base, _Move_assign_base, variant):
> > Remove assertions.
> > (variant::emplace<_Tp>): Remove result of emplace<N> directly.
> >
> > Tested powerpc64le-linux, committed to trunk.
>
> The latter changelog entry should say "Return resulf of emplace<N>
> directly", not "Remove result...".
And yeah, *result*, dunno how that f came into existence instead of a
t. Read it with the right font so that a ligature
hides it. :P