This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] fix copyright year range in libstdc++ test file (was: "Re: [v3 PATCH] Implement std::string_view and P0254r2, Integrating std::string_view and std::string.")


On 01/01/19 09:45 +0400, Joel Brobecker wrote:
Hello,

In working on updating the copyright year notices for the GDB files,
I noticed something very minor regarding the patch which added the
file below (the same file was copied in gdb's testsuite); it looks
like the year range for one of the files is truncated:

   | diff --git a/libstdc++-v3/testsuite/21_strings/basic_string_view/element_access/char/empty.cc b/libstdc++-v3/testsuite/21_strings/basic_string_view/element_access/char/empty.cc
   | new file mode 100644
   | index 0000000..c0f8206
   | --- /dev/null
   | +++ b/libstdc++-v3/testsuite/21_strings/basic_string_view/element_access/char/empty.cc
   | @@ -0,0 +1,40 @@
   | +// { dg-options "-std=gnu++17" }
   | +
   | +// Copyright (C) 3 Free Software Foundation, Inc.

The file was contributed around July 2016, so it should be at least
2016-2018 now, but, looking at all the other test files around,
all ranges start with 2013, so I suspect the intention was for
this file to be the same. This is what the attached patch proposes.

libstdc++-v3/ChangeLog:

	* testsuite/21_strings/basic_string_view/element_access/char/empty.cc:
       Fix year range in copyright header.

OK for trunk?

One a fix pushed to GCC, I will take care of the GDB side.

That file was copied from an older one in the testsuite (which is why
it has a date of 2013). This fixes the older one.

Committed to trunk.


commit 4f2fb88e3108defff663f51ebfddbdfb4a3b751a
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jan 2 10:33:53 2019 +0000

    Fix year range in copyright header
    
            * testsuite/experimental/string_view/element_access/char/empty.cc:
            Fix year range in copyright header.

diff --git a/libstdc++-v3/testsuite/experimental/string_view/element_access/char/empty.cc b/libstdc++-v3/testsuite/experimental/string_view/element_access/char/empty.cc
index 977e41e79ae..299447fefe8 100644
--- a/libstdc++-v3/testsuite/experimental/string_view/element_access/char/empty.cc
+++ b/libstdc++-v3/testsuite/experimental/string_view/element_access/char/empty.cc
@@ -1,6 +1,6 @@
 // { dg-do run { target c++14 } }
 
-// Copyright (C) 3 Free Software Foundation, Inc.
+// Copyright (C) 2013-2019 Free Software Foundation, Inc.
 //
 // This file is part of the GNU ISO C++ Library.  This library is free
 // software; you can redistribute it and/or modify it under the

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]