This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make std::list::iterator == and != global inline friend


On 09/10/18 07:25 +0200, François Dumont wrote:
As we talked one day I would like to make all iterator operators global for consistency. So here is the patch to do so for std::list iterators.

By "global" you mean "non-member", right?


Thanks to this change the operators ==(iterator, const_iterator) and != are not necessary anymore, one less ==|!= operator candidate.

    * include/bits/stl_list.h
    (_List_operator<>::operator==): Make global inline friend.

I find this description a bit confusing. Please use "Replace member
function with inline friend" instead.

    (_List_operator<>::operator!=): Likewise.
    (_List_const_operator<>::operator==): Likewise.
    (_List_const_operator<>::operator!=): Likewise.
    (operator==(const _List_iterator<>&, const _List_const_iterator<>&)):
    Remove.
    (operator!=(const _List_iterator<>&, const _List_const_iterator<>&)):
    Remove.

Tested under Linux x86_64.

Ok to commit ?

OK with the revised changelog text, thanks.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]