This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)
- From: Jason Merrill <jason at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Marek Polacek <polacek at redhat dot com>, Jonathan Wakely <jwakely at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 24 Oct 2017 13:55:58 -0400
- Subject: Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)
- Authentication-results: sourceware.org; auth=none
- References: <20170807090825.GK2123@tucnak> <d8d629b2-86f6-9c1f-f627-814f73274fd1@redhat.com> <20170807152742.GM2123@tucnak> <20170901111249.GD2323@tucnak> <CADzB+2m-cY+mF4SP0wf=GcyDWrRdDePbQKdo59Fd12t=Kpa_kg@mail.gmail.com> <20170912074920.GC1701@tucnak> <20170929123233.GK1701@tucnak> <80f60fe4-f8f3-5da7-23bb-72d8604d838b@redhat.com> <20171024153359.GM14653@tucnak>
On Tue, Oct 24, 2017 at 11:33 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Oct 24, 2017 at 11:06:51AM -0400, Jason Merrill wrote:
>> On 09/29/2017 08:32 AM, Jakub Jelinek wrote:
>> > + tree b = builtin_decl_explicit (DECL_FUNCTION_CODE (newdecl));
>> > + if (b)
>> > + duplicate_one_attribute (&DECL_ATTRIBUTES (b),
>> > + DECL_ATTRIBUTES (newdecl),
>> > + "omp declare simd");
>>
>> It occurs to me that we're likely to want to propagate other attributes to
>> the builtin, too. In the testcase, nothrow and leaf also seem appropriate.
>> Do we want a broader copy_attributes_to_builtin function, even if it only
>> copies this omp attribute for now?
>
> So like this?
I was thinking that the new function would decide which attributes we
want to copy over, rather than have a "name" parameter.
Jason