This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++, patch] Fix build on APFS file system
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Wed, 18 Oct 2017 22:05:20 +0100
- Subject: Re: [libstdc++, patch] Fix build on APFS file system
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jwakely at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2A58849019
- References: <1148963B-29B1-48D5-B295-15A5593AC4B9@gmail.com>
On 18/10/17 16:51 +0200, FX wrote:
Parallel builds of libstdc++ on APFS filesystem (with 1 ns granularity) on macOS 10.13 often fail (failure rate for “make -j2” to “make -j8” is about 60% from my own builds and results reported by others): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81797
This is reproducible with several versions of GNU make.
Changing libstdc++’s makefile to mark install-headers with .NOTPARALLEL fixes the issue. We've carried that patch in Homebrew (https://brew.sh) for a few months now, and have had no report of build issues since then.
Bootstrapped and regtested on x86_64-apple-darwin17 (as well as other platforms). OK to commit?
Could you test using .PHONY: install-headers instead?
That target *is* phony, so telling make that seems sensible.
Presumably the same change is needed for install-freestanding-headers,
since it's very similar.