This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH 4/3] improve detection of attribute conflicts (PR 81544)
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 18 Aug 2017 14:57:11 +0100
- Subject: Re: [PATCH 4/3] improve detection of attribute conflicts (PR 81544)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jwakely at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 214DDC04B329
- References: <4899e27e-6fc3-a887-7888-9f7810a07aaa@gmail.com> <8e37236c-83eb-7c8f-bffd-6f28a2701a10@gmail.com>
On 16/08/17 16:38 -0600, Martin Sebor wrote:
Jon,
Attached is the libstdc++ only patch to remove the pointless
const attribute from __pool<true>::_M_destroy_thread_key(void*).
https://gcc.gnu.org/ml/gcc/2017-08/msg00027.html
I only belatedly now broke it out of the larger patch under
review here:
https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00599.html
Thanks
Martin
libstdc++-v3/ChangeLog:
PR c/81544
* include/ext/mt_allocator.h (_M_destroy_thread_key): Remove
pointless attribute const.
OK.
diff --git a/libstdc++-v3/include/ext/mt_allocator.h b/libstdc++-v3/include/ext/mt_allocator.h
index effb13b..f349ff8 100644
--- a/libstdc++-v3/include/ext/mt_allocator.h
+++ b/libstdc++-v3/include/ext/mt_allocator.h
@@ -355,7 +355,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
}
// XXX GLIBCXX_ABI Deprecated
- _GLIBCXX_CONST void
+ void
_M_destroy_thread_key(void*) throw ();
size_t