This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
What are these "profile" tests for?!
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org
- Date: Fri, 23 Jun 2017 17:49:30 +0100
- Subject: What are these "profile" tests for?!
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7067F42BCE
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7067F42BCE
I've just noticed these three tests which just seems to create very
large containers:
23_containers/unordered_map/profile/hash_map.cc
23_containers/unordered_map/profile/unordered.cc
23_containers/vector/profile/vector.cc
Does anybody know what they're for? They say
// Insert more than default item
They all use the magic number 10000 which occurs in
<profile/impl/profiler_trace.h> so I assume they're trying to test
what happens when some limit is exceeded, but the tests don't actually
use profile mode! Should they be using -D_GLIBCXX_PROFILE? Or are they
only meant to test anything useful when doing "make check-profile"?
Maybe I should hurry up and add SystemTap probe points to the
containers so we can simply delete profile mode.