This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] SFINAE on is_same first in variant's _Tp&& constructor
- From: "Tim Shen via libstdc++" <libstdc++ at gcc dot gnu dot org>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Tim Song <t dot canens dot cpp at gmail dot com>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 28 May 2017 14:29:30 -0700
- Subject: Re: [Patch] SFINAE on is_same first in variant's _Tp&& constructor
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNkZui6RkKB-cydS+q1=xUcuNS42Uha6w-N7fK7GbEOmSw@mail.gmail.com> <20170522132137.GH4527@redhat.com> <CAPQZVxunEz2oPDDjkpsKHg=NsuzQO4yy29rsqHqqRymzF1p+zw@mail.gmail.com> <20170523102444.GB12306@redhat.com>
- Reply-to: Tim Shen <timshen at google dot com>
On Tue, May 23, 2017 at 3:24 AM, Jonathan Wakely wrote:
> On 22/05/17 16:14 -0400, Tim Song wrote:
> Ah I see.
>
>> The original patch does that (assuming core issue 1227's resolution),
>> but the __and_ version doesn't; __and_ only short circuits the
>> immediate parameter, not things used in forming it.
>
>
> Then the original patch is OK for trunk and gcc-7-branch.
>
> Thank you Tim and Tim for the explanations.
>
Committed. I didn't bother using remove_cv<remove_reference<T>> only
because p0088r3 says decay_t.
--
Regards,
Tim Shen