This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Review debug message generation
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 9 Nov 2016 22:57:59 +0000
- Subject: Re: Review debug message generation
- Authentication-results: sourceware.org; auth=none
- References: <bug-77459-19885@http.gcc.gnu.org/bugzilla/> <bug-77459-19885-uESBqtAWiz@http.gcc.gnu.org/bugzilla/> <a4cee4b6-74bf-c910-12c2-d2139c04c5f6@gmail.com>
On 09/11/16 22:36 +0100, François Dumont wrote:
Hi
Here is a proposal to review how we generate the debug output in
case of assertion failure. It removes usage of format_word which, as a
side effect will fix PR 77459. Should I reference this PR in the
ChangeLog ?
Please do either mention the PR in the ChangeLog, or just put a note
in the bugzilla PR that says "fixed by rNNNNN" with the SVN commit
number, to make it easier to know what fixed it.
I introduced a print_literal function to avoid using strlen on
them. I know that gcc optimizes calls to strlen on literals but in our
case we were not directly calling it on the literals.
Tested under Linux x86_64, ok to commit ?
* src/c++11/debug.cc (format_word): Delete.
(print_literal): New. Replace call to print_word for literals.
This is a nice change, OK to commit, thanks.