This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite.
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Matthew Wahab <matthew dot wahab at foss dot arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Wed, 14 Sep 2016 15:37:42 +0200
- Subject: Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite.
- Authentication-results: sourceware.org; auth=none
- References: <57C97BF8.5090601@foss.arm.com> <20160906101528.GA32255@redhat.com> <CAKdteOZ5ey=xsMe=XO2+JJcMrWBAeVjR2rfR_F7J2tOt7zQQFg@mail.gmail.com> <20160914132749.GH17376@redhat.com>
On 14 September 2016 at 15:27, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 14/09/16 15:17 +0200, Christophe Lyon wrote:
>>
>> It seems some tests still have dg-require or dg-skip before dg-do.
>> The attached patch fixes that, the only effect is that
>> 25_algorithms/lower_bound/debug/irreflexive.cc
>> is now UNSUPPORTED instead of PASS on arm* and aarch64* targets.
>>
>> I'm not sure if that's expected. I do see: "#error No debug mode" in the
>> logs.
>
>
> It's expected, because it has dg-require-debug-mode, so the test
> should only run when doing make check-debug, or adding
> -D_GLIBCXX_DEBUG to the options used for testing.
>
> It passes in normal mode too, but doesn't test anything very
> interesting, so doesn't need to be tested.
>
Thanks for the explanation.
Committed as r240135.
Christophe
>> OK for trunk?
>
>
> Yes, thanks.
>
>